Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v0.30.2 #3732

Merged
merged 7 commits into from
Jun 15, 2024
Merged

v0.30.2 #3732

merged 7 commits into from
Jun 15, 2024

Conversation

notgull
Copy link
Member

@notgull notgull commented Jun 15, 2024

0.30.2

Changed

  • On Web, let events wake up event loop immediately when using
    ControlFlow::Poll.

Fixed

  • On Web, fix EventLoopProxy::send_event() triggering event loop immediately
    when not called from inside the event loop. Now queues a microtask instead.
  • On Web, stop overwriting default cursor with CursorIcon::Default.
  • On Web, prevent crash when using InnerSizeWriter::request_inner_size().

@notgull notgull requested a review from daxpedda as a code owner June 15, 2024 02:07
@notgull
Copy link
Member Author

notgull commented Jun 15, 2024

See #3731 for the failing clippy lints

@daxpedda daxpedda added this to the Version 0.30.2 milestone Jun 15, 2024
Copy link
Member

@daxpedda daxpedda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 858b84e commit has to be excluded, as this is is technically a breaking change.

I can do it as well tonight.

Thanks for doing this @notgull!

Not using `NSColor::clearColor()` results in Quartz thinking that the
window is not transparent at all, which results in artifacts.

However, not setting the `windowBackgroundColor` in
`Window::set_transparent` results in border not properly rendered.

Fixes: 94664ff (Don't set the background color)
This is a breaking change, thus revert it for patch series.
@kchibisov
Copy link
Member

@daxpedda check that I've reverted the web correctly, given that there's no dedicated commit for the said breaking change.

Copy link
Member

@daxpedda daxpedda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @kchibisov, Web looks good!

@kchibisov kchibisov merged commit 79aa95b into v0.30.x Jun 15, 2024
52 checks passed
@kchibisov kchibisov deleted the notgull/next branch June 15, 2024 17:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants