Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor exp logic & code cleanup #9

Merged
merged 1 commit into from
Jun 18, 2024

Conversation

iTruth
Copy link
Contributor

@iTruth iTruth commented Jun 18, 2024

just noticed that CosmicTour.cs is not the only incorrect location, Beatmaps.cs & Shop.cs contains the same issue.

@ArjixWasTaken
Copy link
Collaborator

🙏

@ArjixWasTaken
Copy link
Collaborator

I'll leave this open in case you find more places like that

@iTruth
Copy link
Contributor Author

iTruth commented Jun 18, 2024

sigh... It seems like maxExp is not that simple, at least it should not constitute arithmetic sequence.
the reason is I obtained some data:

level exp
1 50
8 3000
12 5000
13 5500
21 15000
25 26000
26 31000

I tried using exponential regression to find the original function, and I got the following function:
ln(y)=6.963+0.1284x
It works well in high level. but for lower levels, the deviation is significant.
to be honest, I think exp is predefined and does not constitute to any function.

by the way, I think this PR should fix the issue, I'll open another PR if I found more issue in the future. you can merge it if you want.

@ArjixWasTaken ArjixWasTaken merged commit 7ae5563 into rustaxion:development Jun 18, 2024
@ArjixWasTaken
Copy link
Collaborator

Oh yeah, since you are going through my code, I just want to apologize in advance for the war crimes I have commited.

pun intented :)

@ArjixWasTaken
Copy link
Collaborator

@iTruth here is the repository for the rust server implementation I was talking about earlier

https://github.com/ArjixWasTaken/rustaxion

currently it can only log the incoming messages, well, the main_cmd, para_cmd and such
the actual payloads are not really parsed yet

I literally started working on this today :)

ArjixWasTaken added a commit that referenced this pull request Jun 18, 2024
Co-authored-by: iTruth <58349472+iTruth@users.noreply.github.com>
Co-authored-by: iTruth <itruth319@qq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants