Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: mobile -> wayland virtual keyboard mapping mismatch #6328

Merged

Conversation

sahilyeole
Copy link
Contributor

Fixes: #5193

  • With a German keyboard y and z are swapped => If Wayland and Android keyboard layout is both US mapping of z and y is correct.
  • Write capital letters does not work using the Shift button from the Android virtual keyboard.
  • Special characters and numbers from Android virtual keyboard sub pages does not work.

Works for android + ios
Non ASCII characters will still not work (doesn't work on desktop -> wayland too)

ios_key.mp4
android_key.mp4

Notes for review:
Currently we only support physical key input emulation on wayland. So I have updated mappings to support characters that requires to press shift+key.

Non ASCII characters will still not work (doesn't work on desktop -> wayland too)

Non ASCII characters works on mobile -> x11 because xdo supports unicode input. I tried using xdo but it has bad compatibility with xwayland, it didn't work for me at all.
I tried other alternatives like wtype and ydotool.
wtype supports unicode but has bad compatibility as it relies on virtual-keyboard protocol which is not well adapted by many wayland compositors yet.
ydotool works on all wayland environments. It uses uinput like us but it has wider mappings support, so I just updated the mappings in our implementation. ydotool does not support non ASCII characters either.

Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>
@rustdesk rustdesk merged commit 7df10b2 into rustdesk:master Nov 9, 2023
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Keyboard mapping mismatch with connection from Android to Debian Wayland
2 participants