Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Follow remote cursor and window focus | Auto display switch #7717

Merged
merged 51 commits into from
Apr 25, 2024
Merged

Feat: Follow remote cursor and window focus | Auto display switch #7717

merged 51 commits into from
Apr 25, 2024

Conversation

beelchester
Copy link
Contributor

Fixes: #7439

Mac:

mac_rd.mp4

Linux:

linux_rd.mov

Windows:

windows_rd.mov

beelchester and others added 17 commits March 28, 2024 07:14
@beelchester
feat: auto switch display on follow remote cursor
6aba6c7 
Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>
@beelchester
feat: auto switch display on follow remote window focus
9a1f193 
Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>
@beelchester
fix build and remove unused imports
35db7d8 
Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>
@beelchester
fix build
c61b556 
Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>
@beelchester
fix build
15d0bd0 
Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>
@beelchester
fix linux get_focused_window_id
bf79ec3 
Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>
@beelchester
lock show remote cursor when follow remote cursor is enabled
ad0ee37 
Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>
@beelchester
fix config
08fcb5b 
Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>
@beelchester
prevent auto display switch on show all display and displays as indiv…
e098efb 
…idual windows

Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>
@beelchester
fix options
6bdeb99 
Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>
@beelchester
fix options
8950a99 
Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>
@beelchester
remove unused function
97b99a5 
Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>
@beelchester
remove unwraps and improve iterations
27ffd53 
Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>
@beelchester
set updateCursorPos to false to avoid interrupting remote cursor
5b684d1 
Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>
@beelchester
Merge branch 'master' into feat/follow_cursor_and_window
c1ec61c
@beelchester
update lang
f655708 
Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>
@beelchester
fix web build
9fb1248 
Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>
@rustdesk
Copy link
Owner

@21pages please help review and test

21pages
21pages requested changes Apr 14, 2024
View reviewed changes
src/client/io_loop.rs Outdated Show resolved Hide resolved
21pages
21pages requested changes Apr 14, 2024
View reviewed changes
src/server/input_service.rs Outdated Show resolved Hide resolved
src/platform/windows.rs Outdated Show resolved Hide resolved
src/server/connection.rs Outdated Show resolved Hide resolved
21pages
21pages requested changes Apr 14, 2024
View reviewed changes
src/platform/linux.rs Outdated Show resolved Hide resolved
21pages
21pages reviewed Apr 14, 2024
View reviewed changes
src/platform/macos.rs Outdated Show resolved Hide resolved
21pages
21pages requested changes Apr 14, 2024
View reviewed changes
flutter/lib/common/widgets/setting_widgets.dart Show resolved Hide resolved
flutter/lib/common/widgets/toolbar.dart Show resolved Hide resolved
src/server/connection.rs Outdated Show resolved Hide resolved
src/client.rs Show resolved Hide resolved
@beelchester
update checks for options and enable in view mode
0ff60b9 
Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>
@beelchester
use focused display index for window focus service
bc5c8e3 
Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>
@beelchester
use window center for windows display focused
f84fe99 
Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>
@beelchester
remove unused imports
a69faf1 
Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>
@beelchester
fix build
399c361 
Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>
@beelchester
use libxdo instead of xdotool
1af5f62 
Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>
@21pages
Copy link
Collaborator

21pages commented Apr 16, 2024 •
edited
Loading

All platforms work now

Problems remaining:
#7717 (comment) 1
#7717 (comment)
#7717 (comment)
The follow checkboxes are enabled when view only, but the options are sent in client.rs and does not take effect, please keep it consistent.

Opt:
#7717 (comment) 2
#7717 (comment)
#7717 (comment)
Ignore display changes at the edges of the screen, check whether AnyDesk has this behavior

@beelchester
No follow options when multi ui session
37ca7d2 
Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>
@beelchester
turn off follow options when not used|prevent msgs
f33ad3a 
Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>
21pages
21pages requested changes Apr 19, 2024
View reviewed changes
flutter/lib/common/widgets/toolbar.dart Outdated Show resolved Hide resolved
@beelchester
use window center for switch in linux
d7cfb6d 
Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>
@beelchester
use subbed display count to prevent switch msgs
526f447 
Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>
@beelchester
Merge remote-tracking branch 'rd/master' into feat/follow_cursor_and_…
e74465a 
…window
@beelchester
fix build
f2b31fa 
Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>
@beelchester
fix web build
b56395f 
Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>
21pages
21pages requested changes Apr 20, 2024
View reviewed changes
src/server/connection.rs Show resolved Hide resolved
src/server/connection.rs Outdated Show resolved Hide resolved
beelchester and others added 3 commits April 20, 2024 13:24
@beelchester
move subbed displays count
de916e8 
Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>
@beelchester
Merge branch 'master' into feat/follow_cursor_and_window
885ad7b
@beelchester
fix build
0124ae6 
Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>
@21pages
Copy link
Collaborator

21pages commented Apr 20, 2024

Follow NAME_POS's no_perms, subscribe

@beelchester
add noperms for window focus
1afba79 
Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>
@beelchester
add subscribe for window focus
cab9064 
Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>
21pages
21pages requested changes Apr 20, 2024
View reviewed changes
Copy link
Collaborator

@21pages 21pages left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rustdesk/src/server/connection.rs

Line 2761 in d920953

s.write().unwrap().subscribe(

@21pages
Copy link
Collaborator

21pages commented Apr 20, 2024

I think it's ready to be merged.

@rustdesk
Copy link
Owner

I will take a look of the code later

rustdesk
rustdesk reviewed Apr 23, 2024
View reviewed changes
src/server/connection.rs Outdated Show resolved Hide resolved
src/server/connection.rs Outdated Show resolved Hide resolved
@beelchester
remove window_focus message and unsub on multi ui
f31dede 
Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>
@beelchester
add multi ui session field
ffe5638 
Signed-off-by: Sahil Yeole <sahilyeole93@gmail.com>
@rustdesk rustdesk merged commit 3811f41 into rustdesk:master Apr 25, 2024
22 checks passed
@bbhtt bbhtt mentioned this pull request May 12, 2024
Closed
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rustdesk rustdesk rustdesk left review comments

@21pages 21pages 21pages approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Auto Screen-switch / Mouse follow
3 participants
@beelchester @rustdesk @21pages