-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add com.rustdesk.RustDesk #5233
Conversation
com.rustdesk.RustDesk.json
Outdated
"--filesystem=home", | ||
"--device=dri", | ||
"--socket=pulseaudio", | ||
"--talk-name=org.freedesktop.Flatpak" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is not allowed by default. Why is this required?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is remote desktop software, these are required to run it. Please check anydesk https://github.com/flathub/com.anydesk.Anydesk/blob/master/com.anydesk.Anydesk.json
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm going to need more than that. What specifically do you need to run on host that requires escaping the sandbox?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also this is not allowed by default, you are going to need an exception. Otherwise it won't build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it is required to make this feature works?
Or if have any other methods that have smaller permission and won't interfere this feature?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please check this, rustdesk/rustdesk#1537 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AnyDesk does not need to use this because it support x11 only, but we support x11 and wayland both, we need this feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We add these features not for playing, it is because we really need. Hope you can understand.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it is required to make this feature works?
Or if have any other methods that have smaller permission and won't interfere this feature?
rustdesk/rustdesk#7717Why would a feature related to cursors require executing arbitrary commands on host?
Ignore this.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok that makes sense. Thanks. However I see fallbacks everywhere in case loginctl does not work. Is that not enough?
com.rustdesk.RustDesk.json
Outdated
"--socket=fallback-x11", | ||
"--socket=wayland", | ||
"--share=network", | ||
"--filesystem=home", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do you need home?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
They are Remote Desktop software, transfer files is needed for end users
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
File transfer
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does it support filechooser portals? Do you need permanent access to a specific directory?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why does AnyDesk flathub have home? But we can not have
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not answer anything... Each application is separate just because someone else uses it doesn't mean you have to as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok, I give up. Thanks for your time.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This does not answer anything... Each application is separate just because someone else uses it doesn't mean you have to as well.
I do not think so, you answer nothing either.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is ridiculous that the previous reviewer agreed with the home permission of remote desktop software, now a new reviewer does not agree with it. Though all of you are volunteers or students, you should do things like this way.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what's ridiculous is that
- you think you know better
- it's not about what the app does but how it is written
- until recently filesystem permissions were not gated so they could have been changed
- talking about double standard, you are making one right now by thinking you know better while not even being able to justify the choices made when asked.
Locking this thread now since the PR is closed.
You have not:
|
@xlionjuan do you have interest to take over the job of merging RustDesk to flathub? I can add you as maintainer of |
Co-authored-by: bbhtt <bbhtt.zn0i8@slmail.me>
@rustdesk Thanks for your recognition, but sorry, I might not be able to maintain it because I'm not familiar with this either. |
"bsdtar -zxvf rustdesk.deb", | ||
"tar -xvf ./data.tar.xz", | ||
"rm -rf usr/share/icons/hicolor/scalable/", | ||
"cp -r usr/* /app/", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see the metainfo info being installed. You removed it from here, but it is not present in the .deb
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do you know not installed? I did see installed from log of flatpak-build.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How can it be installed when it is not in the deb and nowhere in the manifest as a source?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is closed, you do not need to review any more. #5233 (comment)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since you seem to know better, neither of the line above show the appstream file. So yeah the appstream file isn't installed.
Since we can not reach consensus with reviewers about the permissions, we decide to give up uploading RustDesk to FlatHub. Please use Flatpak from our github release downloads. Thanks for your understanding. |
RustDesk is an open-source remote desktop, and alternative to TeamViewer.
Please confirm your submission meets all the criteria