Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New mzio version based on initial commit of mzcore #5

Open
wants to merge 15 commits into
base: main
Choose a base branch
from

Conversation

david-bouyssie
Copy link
Contributor

Additiona changes:

  • introduce a Cargo.toml for a workspace organization
  • MGF reader improved for speed
  • introduce the MgfSpectrum struct containing MgfSpectrumHeader and SpectrumData (more fine-grained data representation)
  • FASTA API change (configuration at reader/writer construction, allow to access the plain header)
  • fix FASTA unit tests on Windows (CRLF vs LF)
  • mzio-py updated to favor the use of core::Result

…l changes:

* introduce a Cargo.toml for a workspace organization
* MGF reader improved for speed
* introduce the MgfSpectrum struct containing MgfSpectrumHeader and SpectrumData (more fine-grained data representation)
* FASTA API change (configuration at reader/writer construction, allow to access the plain header)
* fix FASTA unit tests on Windows (CRLF vs LF)
* mzio-py updated to favor the use of core::Result
@david-bouyssie
Copy link
Contributor Author

david-bouyssie commented Oct 23, 2023

mzio now depends on mzcore, however since mzcore is not published yet, I'm referrencing it locally using a relative path to mzcore.
This means that mzio and mzcore repos have currently to be sibling directories on the file system (either CI or your any computer used to build this repo).

@lazear
Copy link

lazear commented Oct 23, 2023

mzio now depends on mzcore, however since mzcore is not published yet, I'm referrencing it locally using a relative path to mzcore. This means that mzio and mzcore repos have currently to be sibling directories on the file system (either CI or your any computer used to build this repo).

For cargo deps, you can add github dependencies (including pinning to a certain branch or commit):

[dependencies]
sage-core = { git = "https://github.com/lazear/sage.git" }
```

@david-bouyssie
Copy link
Contributor Author

david-bouyssie commented Oct 23, 2023

Very nice tip! This would avoid my hacky Python CI, to clone the repo before the build.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants