-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Test rustler_mix generated files #266
Conversation
`path` is determined from the name and not passed in as an argument.
The dependency is not needed to be mentioned explicitly anymore.
@scrogson I wonder why there does not seem to be CI running for this PR. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
Just noticed in the shell script there are 4 spaces instead of 2 in the last bit.
That's odd. |
Oh...maybe it has to do with it being your fork? I've been making PRs against the real repo. So maybe the GitHub actions config needs tweaking? |
|
@NobbZ, yeah, but I've noticed that when you use |
I think we should do that for now, I already broke CI here without realizing it (fix in #268). |
This pull request adds a shell script to test that the files generated by
rustler_mix
work when used to create a new crate. I fixed some small issues while implementing the script, and extended the mix task to allow specifying the module, name and otp app on the command line.