Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test rustler_mix generated files #266

Merged
merged 6 commits into from
Oct 27, 2019
Merged

Conversation

evnu
Copy link
Member

@evnu evnu commented Oct 27, 2019

This pull request adds a shell script to test that the files generated by rustler_mix work when used to create a new crate. I fixed some small issues while implementing the script, and extended the mix task to allow specifying the module, name and otp app on the command line.

@evnu evnu requested a review from a team October 27, 2019 16:55
@evnu evnu changed the title Test template Test rustler_mix generated files Oct 27, 2019
@evnu
Copy link
Member Author

evnu commented Oct 27, 2019

@scrogson I wonder why there does not seem to be CI running for this PR.

Copy link
Member

@scrogson scrogson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Just noticed in the shell script there are 4 spaces instead of 2 in the last bit.

rustler_mix/test.sh Outdated Show resolved Hide resolved
@scrogson
Copy link
Member

I wonder why there does not seem to be CI running for this PR.

That's odd.

@scrogson
Copy link
Member

Oh...maybe it has to do with it being your fork? I've been making PRs against the real repo. So maybe the GitHub actions config needs tweaking?

@NobbZ
Copy link
Contributor

NobbZ commented Oct 27, 2019

on: push means on pushing to the repo directly, if you want to have the CI run on pushes to the repository and on pull requests, you need to on: [push, pull_request] (or was it pr?).

@scrogson
Copy link
Member

on: push means on pushing to the repo directly, if you want to have the CI run on pushes to the repository and on pull requests, you need to on: [push, pull_request] (or was it pr?).

@NobbZ, yeah, but I've noticed that when you use on: [push, pull_request] everything is run twice (once for the push and once for pull_request).

@evnu evnu merged commit e850c06 into rusterlium:master Oct 27, 2019
@evnu evnu deleted the test-template branch October 27, 2019 19:08
@evnu evnu mentioned this pull request Oct 27, 2019
@evnu
Copy link
Member Author

evnu commented Oct 27, 2019

yeah, but I've noticed that when you use on: [push, pull_request] everything is run twice (once for the push and once for pull_request).

I think we should do that for now, I already broke CI here without realizing it (fix in #268).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants