Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustler_mix: Fix template test on Elixir < 1.9 #269

Merged
merged 3 commits into from
Oct 29, 2019

Conversation

evnu
Copy link
Member

@evnu evnu commented Oct 27, 2019

Another fix for #266 (d7552b4). This also adds the event pull_request to github actions in order to try to test this PR before it hits master. We can drop this commit when CI succeeded.

@evnu
Copy link
Member Author

evnu commented Oct 27, 2019

@scrogson Can you take a look why CI is failing? The error messages are not particularly helpful:

image

Maybe there are two many concurrent jobs and they are cancelled?

@scrogson
Copy link
Member

@scrogson
Copy link
Member

We can pull this check out into its own yml file and only run on stable and latest Erlang/Elixir. This is what I did for the Clippy and Format checks.

@scrogson
Copy link
Member

Sorry I was wrong about the separation file. But we can either pull it into its own section or create a separate file.

@evnu
Copy link
Member Author

evnu commented Oct 27, 2019

I pulled the test into its own step with 208fdd0, which worked on CI. I think 6e8a205 already fixed it, but CI somehow stumbled over the large number of builds..(?) In any case, running this test only once should be sufficient to pick up simple errors where the templates are not updated.

@evnu evnu force-pushed the fix-template-test branch 2 times, most recently from 8a81626 to 9fb22ea Compare October 27, 2019 21:40
@evnu
Copy link
Member Author

evnu commented Oct 27, 2019

Alright, this seems to work now. The original fix in this PR was indeed not enough. @scrogson should I leave 158d4f6 in or drop it?

@scrogson scrogson merged commit 4ed4822 into rusterlium:master Oct 29, 2019
@evnu evnu deleted the fix-template-test branch October 29, 2019 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants