Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add contribute.json to the website #10

Merged
merged 1 commit into from
Nov 18, 2019
Merged

Add contribute.json to the website #10

merged 1 commit into from
Nov 18, 2019

Conversation

nbraud
Copy link
Contributor

@nbraud nbraud commented Nov 18, 2019

contribute.json is an initiative from Mozilla to provide human- and machine-readable metadata describing how to contribute to a given web site/service or repository.

@nbraud nbraud requested a review from a team as a code owner November 18, 2019 02:26
@netlify
Copy link

netlify bot commented Nov 18, 2019 •
edited
Loading

Deploy preview for condescending-bhaskara-d5a97a ready!

Built with commit 2453d5d

https://deploy-preview-10--condescending-bhaskara-d5a97a.netlify.com

@nbraud
Copy link
Contributor Author

nbraud commented Nov 18, 2019

Ideally, the contribute.json file should also be present at the root of the repo, and checked against the schema during CI.
That sounds like too much work for 3.30am

@nbraud
Add contribute.json to the website
2453d5d 
[contribute.json] is an initiative from Mozilla to provide human- and
machine-readable metadata describing how to contribute to a given web
site/service or repository.

[contribute.json]: https://www.contributejson.org/
@reuvenpo
Copy link
Contributor

We could write a small python script that fetches the raw schema file from github and uses jsonschema@pypi to validate it against this file.

@nbraud
Copy link
Contributor Author

nbraud commented Nov 18, 2019

We could write a small python script that fetches the raw schema file from github and uses jsonschema@pypi to validate it against this file.

Yuh, that's pretty much what I had in mind. :3
Do you think it's reasonable to leave it for a later PR though?

@reuvenpo
Copy link
Contributor

Yeah, of course. It's only useful when run in CI, and there aren't that many maintainers yet, so it's not really important. :)

@nbraud nbraud merged commit 2453d5d into main Nov 18, 2019
@nbraud nbraud mentioned this pull request Nov 18, 2019
Open
@nbraud nbraud deleted the contribute.json branch November 18, 2019 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@reuvenpo reuvenpo reuvenpo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nbraud @reuvenpo