Add HttpsConnectorBuilder #145
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This gives more control over various rustls features, as well as ensures that enabling connector features like http2 can only be done when the appropriate crate features are enabled. Adds an hyper-rustls/http2 feature.
These functions implicitly enabled certificate transparency, keep that as well.
|
I didn't see this when it was originally submitted but I agree this is better than doing it through a feature. |
|
Do I need to do anything here? Now that #155 is waiting for this PR to be merged, I'd like to get this in as well. |
|
Rebasing this on top of #153 makes sense, I think (I can now also merge PRs in this project). |
|
With #156, I think this is no longer needed, right? |
|
Right! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This gives more control over various rustls features,
as well as ensures that enabling connector features
like http2 can only be done when the appropriate crate
features are enabled.
Adds an hyper-rustls/http2 feature, fixing #143.
This is an alternative to the fix in #144, my motivation is that crate features can be activated at a remote whereas an explicit method call removes ambiguity.