Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to rustls 0.20 #153

Closed
wants to merge 1 commit into from
Closed

Upgrade to rustls 0.20 #153

wants to merge 1 commit into from

Conversation

djc
Copy link
Member

@djc djc commented Jul 6, 2021

This is blocked on tokio-rustls and rustls-native certs releasing updates, first.

@g2p
Copy link
Contributor

g2p commented Sep 30, 2021

There's a remaining issue with the released version of rustls, this doesn't build as is because rustls now forces users to figure out how long they trust a list of logs to be current (after which the default verifier fails open), while rustls is a bit more lax than Chrome (checking just one log), users expecting hyper-rustls to connect to any server that Chrome will connect to would need hyper-rustls to embed at build time a time stamp from when the list of ct-logs was last checked to be current.
I don't think we can do that, plus the ct-logs crate isn't current at the moment, so I don't think we can enable sct validation out of the box like before. See also rustls/ct-logs#10

@djc
Copy link
Member Author

djc commented Oct 5, 2021

I agree that for now it's probably better to keep CT validation disabled for now.

@djc
Copy link
Member Author

djc commented Nov 15, 2021

Finished off in #156.

@djc djc closed this Nov 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants