fix: can't resolve ip address with square brackets #182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djc
reviewed
Dec 6, 2022
CryZe
reviewed
Dec 6, 2022
digitwolf
force-pushed
the
main
branch
2 times, most recently
from
e0dca11
to
2d7cd36
Compare
Problem: Sending to destination like https://[::1]/ fails with error invalid dnsname. Error is thrown here https://github.com/rustls/hyper-rustls/blob/main/src/connector.rs#L95 hyper-rustls resolves the Hostname as hyper::Uri::host This makes hostname = "[::1]" which is HTTP-specific form of writing IPv6 address. Solution: Since square brakets are coming from hyper and not part standard IP notation we remove any square brakets inside of the connector before calling the rustls::ServerName::try_from(hostname)
djc
approved these changes
Dec 6, 2022
|
djc, I think I hit the wrong button, please approve the workflow again |
|
Okay, thanks! |
|
Thank you for merging djc! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem:
Sending to destination like https://[::1]/ fails with error invalid dnsname. Error is thrown here https://github.com/rustls/hyper-rustls/blob/main/src/connector.rs#L95
hyper-rustls resolves the Hostname as hyper::Uri::host This makes hostname = "[::1]" which is HTTP-specific form of writing IPv6 address.
Solution:
Since square brakets are coming from hyper and not part standard IP notation we remove any square brakets inside of the connector before calling the rustls::ServerName::try_from(hostname)