Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prepare 0.11.0 release. #338

Merged
merged 3 commits into from
Jul 18, 2023
Merged

Prepare 0.11.0 release. #338

merged 3 commits into from
Jul 18, 2023

Conversation

cpu
Copy link
Member

@cpu cpu commented Jul 14, 2023

Description

This branch prepares for the 0.11.0 release.

  • Updated CHANGELOG with new version + date
  • Checked for outdated library dependencies
  • Tests pass locally with --all-features and --no-default-features
  • Updated Cargo.toml with new version
  • cargo publish --dry-run succeeds

docs: update README to match MSRV.

The project MSRV was increased to 1.60 in #322 - this commit updates the README to match.

docs: update CHANGELOG for 0.11.0 release.

This commit updates the CHANGELOG. I've tried to strike the right balance between covering the changes and not providing too much unnecessary detail. In particular I didn't call out each of the _new and _free renames in the Changed section, just the top level type name changes. Similarly in the Added section I didn't describe each of the new builder functions, but the overall idea. If preferred I can update both sections to cover each change in finer detail.

cargo: bump version 0.10.0 -> 0.11.0

Does what it says on the tin. The changes in main are semver incompatible so we can't do this as a minor point release.

@cpu cpu requested a review from jsha July 14, 2023 14:02
Copy link
Member

@ctz ctz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

Copy link
Collaborator

@jsha jsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👍🏻

@cpu cpu merged commit 7b1839d into rustls:main Jul 18, 2023
21 checks passed
@cpu cpu deleted the cpu-prep-0.11.0 branch July 18, 2023 12:55
@cpu
Copy link
Member Author

cpu commented Jul 18, 2023

@jsha Would you like me to publish this release to https://crates.io/ or would you prefer to do it? Is there anything special that needs to happen compared to the other Rustls repos? Thanks for the review!

@jsha
Copy link
Collaborator

jsha commented Jul 20, 2023

If you could do the publish to crates.io that would be great, to make sure we have multiple people with the privileges. For this repo, though, the push to crates.io is secondary. The main way we expect people to consume it is by checking out a tagged release from this repository. So, could you also create a tag and a GitHub Release? Thanks!

@cpu
Copy link
Member Author

cpu commented Jul 20, 2023

If you could do the publish to crates.io that would be great, to make sure we have multiple people with the privileges

@jsha I think you (or another owner) might need to update the crate settings to allow the rustls-publishers group that ctz created for the other crates to be able to publish rustls-ffi. I'm a member of that group but publishing is giving me this error:

error: failed to publish to registry at https://crates.io

Caused by:
  the remote server responded with an error: this crate exists but you don't seem to be an owner. If you believe this is a mistake, perhaps you need to accept an invitation to be an owner before publishing.

So, could you also create a tag and a GitHub Release? Thanks!

Done! v0.11.0.

@cpu
Copy link
Member Author

cpu commented Jul 24, 2023

@jsha gentle bump on this - Did you catch Ctz's follow-up in Discord?

@jsha
Copy link
Collaborator

jsha commented Jul 24, 2023

Thanks for the bump! Just added the group.

@cpu
Copy link
Member Author

cpu commented Jul 24, 2023

Thank you!

Published rustls-ffi v0.11.0 at registry crates-io

I think we're all set 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants