Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: replace "nb." with "Note:" #1615

Merged
merged 1 commit into from
Nov 22, 2023
Merged

doc: replace "nb." with "Note:" #1615

merged 1 commit into from
Nov 22, 2023

Conversation

jsha
Copy link
Contributor

@jsha jsha commented Nov 21, 2023

"nota bene" (mark well) is jargon that we don't need.

Note: I wouldn't bother with this but I noticed it in the public documentation for KeyBlockShape. I figure it's valuable to use less jargon in the public docs when possible, and I might as well tweak the internal-facing uses as well.

"nota bene" (mark well) is jargon that we don't need.
@jsha jsha changed the title Doc: replace "nb." with "Note:" doc: replace "nb." with "Note:" Nov 21, 2023
Copy link

codecov bot commented Nov 21, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1db4506) 95.73% compared to head (145fdab) 95.73%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1615   +/-   ##
=======================================
  Coverage   95.73%   95.73%           
=======================================
  Files          79       79           
  Lines       16188    16188           
=======================================
  Hits        15498    15498           
  Misses        690      690           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"nota bene" (mark well) is jargon that we don't need.

Agreed, thanks for fixing this up. I couldn't spot any other instances outside the ones fixed in this branch.

@cpu cpu added this pull request to the merge queue Nov 22, 2023
Merged via the queue into rustls:main with commit db64448 Nov 22, 2023
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants