make the provider-example library no-std compatible (almost)
#1636
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1636 +/- ##
=======================================
Coverage 95.90% 95.90%
=======================================
Files 78 78
Lines 16083 16083
=======================================
Hits 15424 15424
Misses 659 659 ☔ View full report in Codecov by Sentry. |
the git versions of the hpke-rs crates are now no-std compatible. I have requested for new releases on crates.io in franziskuskiefer/hpke-rs#60 |
pvdrz
force-pushed
the
no-std-provider-example-lib
branch
3 times, most recently
from
2b9536b
to
d242a46
Compare
|
I bumped the hpke crates versions and fixed some small incompatibilities. This is ready for review. |
provider-example/Cargo.toml
Outdated
| @@ -11,11 +11,11 @@ chacha20poly1305 = { version = "0.10.0", default-features = false, features = [" | |||
| der = "0.7.0" | |||
| ecdsa = "0.16.8" | |||
| hmac = "0.12.0" | |||
| hpke-rs = { version = "0.1.2", optional = true } | |||
There was a problem hiding this comment.
It would be good to move this commit up above "introduce a "std" Cargo feature", which should remove some of the back-and-forth
There was a problem hiding this comment.
great, could you edit this part of the commit message?
hpke is gated behind the feature because as of v0.1.2 it does not have
no-std support
pvdrz
force-pushed
the
no-std-provider-example-lib
branch
2 times, most recently
from
c1a44ad
to
96a7a6f
Compare
for use in in-tree examples.
this has been extracted out of #1534 and it's the part that has run into merge conflicts more often in the last few weeks so I'd like to land it ahead of time.
provider-exampleis almost no-std compatible becauserustlsis not no-std compatible until #1502 lands. still this PR gets more of the no-std compatibility done and only a few Cargo.toml changes are needed after #1502 lands.the latest crates.io release of
hpkeis not no-std compatible but I've send a bunch of PRs to fix that