v0.22.1 preparation #1677

cpu · 2023-12-07T15:02:30Z

Description

This branch targets the rel-0.22 feature branch, which was created at commit e051f5c - the last semver compatible update to main after the 0.22 release.

It brings in the following PRs since then:

It skips these PRs from main that I believe are semver incompatible:

Proposed Release Notes

TLS 1.2 servers now remove session tickets after observing a failure to decrypt, preventing future resumption with the same unusable ticket.
The rustls_pki_types crate is now re-exported as rustls::pki_types.
The crate examples examples have been updated to use the rustls::pki_types re-export.
The quic::PacketKey and quic::HeaderProtectionKey traits are now Send + Sync.
Performance improvements to the MessageDeframer internals.
Small documentation improvements.

if for some reason the recorded session ticket is invalid or decoded incorrectly by the server, we can get into a case where the resumption handshake happens, and right after the ChangeCipherSpec message, the server sends an encrypted handhsake message using the invalid ticket, and the client rejects it with the BadRecordMAC alert. Unfortunately, if the calling code retries the connection, if it will try again with the same ticket and obtain the same result. This commit makes sure that if we fail to decrypt the first message, we will remove the session ticket for this server, to start from cratch on the next connection.

djc · 2023-12-07T15:23:47Z

As mentioned in #1665, I think we should bring that in even though it is technically semver-incompatible. Also I don't think #1595 is semver-incompatible (just looked it over, I think there was also a comment from @ctz stating it only made incompatible changes to the internals API). Not sure if we want to backport it? Might improve performance a bit.

cpu · 2023-12-07T15:26:29Z

As mentioned in #1665, I think we should bring that in even though it is technically semver-incompatible

Oops, missed that comment. I'll pull that in.

Also I don't think #1595 is semver-incompatible (just looked it over, I think there was also a comment from @ctz stating it only made incompatible changes to the internals API).

Right again. I'll add it to the branch 👍

Without the context of RFC 8446 in your mind the use of the `ProtocolVersion::TLSv1_2` constant in the TLS 1.3 `MessageEncrypter` implementations appears like an oversight or copy/paste error. This commit adds a brief explanatory comment.

cpu · 2023-12-07T15:34:23Z

I've updated the branch to bring in the quic trait and message deframer changes. The PR description and proposed release notes are updated as well.

codecov · 2023-12-07T15:35:02Z

Codecov Report

Attention: 6 lines in your changes are missing coverage. Please review.

Comparison is base (e051f5c) 95.90% compared to head (7b2171f) 95.90%.

Files	Patch %	Lines
rustls/src/msgs/deframer.rs	97.14%	6 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           rel-0.22    #1677    +/-   ##
==========================================
  Coverage     95.90%   95.90%            
==========================================
  Files            78       78            
  Lines         16083    16211   +128     
==========================================
+ Hits          15424    15547   +123     
- Misses          659      664     +5

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ctz · 2023-12-07T15:38:02Z

As mentioned in #1665, I think we should bring that in even though it is technically semver-incompatible.

Technically, but I think it is the only way to get valid code to compile, so 🤷🏽‍♂️

I guess this makes rel-0.22 = main, but minus b2cd886?

cpu · 2023-12-07T15:39:28Z

I guess this makes rel-0.22 = main, but minus b2cd886?

There are a couple other changes absent from this branch (enumerated in the PR desc): The provider example no-std work (and follow-up tweaks), as well as the change marking SupportedProtocolVersion non-exhaustive.

djc · 2023-12-07T15:39:34Z

Well, also #1673 (and #1672, of course).

cpu · 2023-12-07T15:40:29Z

#1668 might be a good candidate for a 0.21.x release too. WDYT?

djc · 2023-12-07T15:41:26Z

I think we should limit 0.21.x to bugfixes only, which #1668 doesn't qualify as?

cpu · 2023-12-07T15:45:06Z

It smells like a bug to me (a client getting stuck in a retry loop), but I don't feel strongly and if nobody is asking for it I'm happy to skip the extra work.

djc · 2023-12-07T15:48:22Z

Uh, sorry, I was confused. But you already have #1668 in your list of things that you included in the PR description?

cpu · 2023-12-07T15:51:00Z

But you already have #1668 in your list of things that you included in the PR description?

Right, for this 0.22.1 release. I'm suggesting it might make sense to also create a separate backport branch with just that PR for a 0.21.10 bugfix release. Does that make sense?

djc · 2023-12-07T15:57:03Z

Uggh, my brain is a bit fried I guess. Yeah, I think that makes sense.

cpu · 2023-12-07T16:44:52Z

Yeah, I think that makes sense.

#1678

djc

(Including the addition of #1679.)

We now re-export the rustls-pki-types crate. I think that means our preferred way for crates to consume pki-types is through the re-exports.

cpu · 2023-12-08T13:48:53Z

(Including the addition of #1679.)

Added. PR desc and proposed release notes updated.

cpu · 2023-12-08T14:11:49Z

Pushed v/0.22.1 tag
Created 0.22.1 GitHub release
Published rustls v0.22.1 at registry crates-io

omegablitz and others added 2 commits December 7, 2023 09:53

doc: fix outdated documentation

b4e99cc

cpu self-assigned this Dec 7, 2023

cpu mentioned this pull request Dec 7, 2023

Re-export the types crate contents #1674

Merged

cpu changed the base branch from main to rel-0.22 December 7, 2023 15:03

japaric and others added 11 commits December 7, 2023 10:30

deframer: move helpers after tests

08d8160

Make assert_len more succint

438fb10

extract out MessageDeframer buffer

3a24530

make MessageDeframer unbuffered

95ebf4a

make append_hs generic

88549ae

Introduce DeframerSliceBuffer

da8e2ea

Batch discard operations

93cde38

quic: require that PacketKey and HeaderProtectionKey are Send + sync

0890fe3

suites: move Debug impl below inherent impl

231aa73

Re-export the rustls-pki-types crate contents

04de127

cpu force-pushed the cpu-0.22.1-prep branch from d6bed10 to 04de127 Compare December 7, 2023 15:30

cpu closed this Dec 7, 2023

cpu reopened this Dec 7, 2023

cpu mentioned this pull request Dec 7, 2023

update examples to use pki_types re-export #1679

Merged

djc approved these changes Dec 8, 2023

View reviewed changes

jsha and others added 2 commits December 8, 2023 08:47

update examples to use pki_types re-export

8b597f8

We now re-export the rustls-pki-types crate. I think that means our preferred way for crates to consume pki-types is through the re-exports.

Cargo: version 0.22.0 -> 0.22.1

7b2171f

cpu force-pushed the cpu-0.22.1-prep branch from b5d0172 to 7b2171f Compare December 8, 2023 13:47

cpu enabled auto-merge December 8, 2023 13:48

cpu added this pull request to the merge queue Dec 8, 2023

Merged via the queue into rustls:rel-0.22 with commit 62751aa Dec 8, 2023
22 of 23 checks passed

cpu deleted the cpu-0.22.1-prep branch December 8, 2023 14:04

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

v0.22.1 preparation #1677

v0.22.1 preparation #1677

cpu commented Dec 7, 2023 •

edited

Loading

djc commented Dec 7, 2023 •

edited

Loading

cpu commented Dec 7, 2023

cpu commented Dec 7, 2023

codecov bot commented Dec 7, 2023 •

edited

Loading

ctz commented Dec 7, 2023

cpu commented Dec 7, 2023

djc commented Dec 7, 2023

cpu commented Dec 7, 2023

djc commented Dec 7, 2023

cpu commented Dec 7, 2023

djc commented Dec 7, 2023

cpu commented Dec 7, 2023

djc commented Dec 7, 2023

cpu commented Dec 7, 2023 •

edited

Loading

djc left a comment

cpu commented Dec 8, 2023

cpu commented Dec 8, 2023

v0.22.1 preparation #1677

v0.22.1 preparation #1677

Conversation

cpu commented Dec 7, 2023 • edited Loading

Description

Proposed Release Notes

djc commented Dec 7, 2023 • edited Loading

cpu commented Dec 7, 2023

cpu commented Dec 7, 2023

codecov bot commented Dec 7, 2023 • edited Loading

Codecov Report

ctz commented Dec 7, 2023

cpu commented Dec 7, 2023

djc commented Dec 7, 2023

cpu commented Dec 7, 2023

djc commented Dec 7, 2023

cpu commented Dec 7, 2023

djc commented Dec 7, 2023

cpu commented Dec 7, 2023

djc commented Dec 7, 2023

cpu commented Dec 7, 2023 • edited Loading

djc left a comment

Choose a reason for hiding this comment

cpu commented Dec 8, 2023

cpu commented Dec 8, 2023

cpu commented Dec 7, 2023 •

edited

Loading

djc commented Dec 7, 2023 •

edited

Loading

codecov bot commented Dec 7, 2023 •

edited

Loading

cpu commented Dec 7, 2023 •

edited

Loading