-
Notifications
You must be signed in to change notification settings - Fork 619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
macros: allow trailing enum_builder comma #1725
Conversation
Without allowing a trailing comma for invocations of the `enum_builder!` macro we end up creating messy two line diffs for every addition to an existing built enum. This commit updates the macro definition to allow an optional trailing comma.
Now that the `enum_builder!` macro allows a trailing comma this commit updates each usage to include one. This will make any future diffs that add elements to these enums easier to review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1725 +/- ##
=======================================
Coverage 96.16% 96.16%
=======================================
Files 80 80
Lines 17345 17345
=======================================
Hits 16680 16680
Misses 665 665 ☔ View full report in Codecov by Sentry. |
Benchmark resultsInstruction countsSignificant differencesClick to expand
Other differencesClick to expand
Wall-timeSignificant differencesThere are no significant wall-time differences Other differencesClick to expand
Additional informationCheckout details:
|
Woo, thanks for fixing that up! |
Small quality of life improvement pulled out of a suggestion from djc on #1718.
Without allowing a trailing comma for invocations of the
enum_builder!
macro we end up creating messy two line diffs for every addition to an existing built enum.This branch updates the macro definition to allow an optional trailing comma, and then once the macro allows a trailing comma each usage is updated to include one. This will make any future diffs that add elements to these enums easier to review.