macros: allow trailing enum_builder comma #1725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without allowing a trailing comma for invocations of the `enum_builder!` macro we end up creating messy two line diffs for every addition to an existing built enum. This commit updates the macro definition to allow an optional trailing comma.
Now that the `enum_builder!` macro allows a trailing comma this commit updates each usage to include one. This will make any future diffs that add elements to these enums easier to review.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1725 +/- ##
=======================================
Coverage 96.16% 96.16%
=======================================
Files 80 80
Lines 17345 17345
=======================================
Hits 16680 16680
Misses 665 665 ☔ View full report in Codecov by Sentry. |
Benchmark resultsInstruction countsSignificant differencesClick to expand
Other differencesClick to expand
Wall-timeSignificant differencesThere are no significant wall-time differences Other differencesClick to expand
Additional informationCheckout details:
|
|
Woo, thanks for fixing that up! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small quality of life improvement pulled out of a suggestion from djc on #1718.
Without allowing a trailing comma for invocations of the
enum_builder!macro we end up creating messy two line diffs for every addition to an existing built enum.This branch updates the macro definition to allow an optional trailing comma, and then once the macro allows a trailing comma each usage is updated to include one. This will make any future diffs that add elements to these enums easier to review.