msgs/handshake.rs: remove get_ fn prefixes #1726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unfortunately "type" is not a valid fn identifier, so we use "ext_type".
Again, `type` isn't valid so we use `ext_type`.
…thorities_extension
…oding_for_binder_signing
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1726 +/- ##
==========================================
- Coverage 96.16% 96.16% -0.01%
==========================================
Files 80 80
Lines 17345 17340 -5
==========================================
- Hits 16680 16675 -5
Misses 665 665 ☔ View full report in Codecov by Sentry. |
Benchmark resultsInstruction countsSignificant differencesClick to expand
Other differencesClick to expand
Wall-timeSignificant differencesThere are no significant wall-time differences Other differencesClick to expand
Additional informationCheckout details:
|
A couple of the AWS LC RS benchmarks seem to be a bit noise-y again. Findings were raised here and on #1725 and both are no-op PRs. |
They have been disturbed because I changed some of the test names in #1706. AIUI it will eventually self-correct based on past results. |
Ahhh! yes, I remember reading your note about that now. Thanks for the reminder 👍 |
This was referenced Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a stylistic tidying pulled out of review feedback from djc on #1718 - we want to avoid proliferating new
get_xxxfns in this file, but there are so many existing usages that it would be a jarring inconsistency to change style for new fns.Instead, this branch fixes all of the existing instances in one go so that moving forward we can avoid the
get_prefix while maintaining consistency. We already call out avoidingget_prefixes in our style guide.