-
Notifications
You must be signed in to change notification settings - Fork 619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
msgs/handshake.rs: remove get_ fn prefixes #1726
Conversation
Unfortunately "type" is not a valid fn identifier, so we use "ext_type".
Again, `type` isn't valid so we use `ext_type`.
…thorities_extension
…oding_for_binder_signing
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1726 +/- ##
==========================================
- Coverage 96.16% 96.16% -0.01%
==========================================
Files 80 80
Lines 17345 17340 -5
==========================================
- Hits 16680 16675 -5
Misses 665 665 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Benchmark resultsInstruction countsSignificant differencesClick to expand
Other differencesClick to expand
Wall-timeSignificant differencesThere are no significant wall-time differences Other differencesClick to expand
Additional informationCheckout details:
|
A couple of the AWS LC RS benchmarks seem to be a bit noise-y again. Findings were raised here and on #1725 and both are no-op PRs. |
They have been disturbed because I changed some of the test names in #1706. AIUI it will eventually self-correct based on past results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍🏽
Ahhh! yes, I remember reading your note about that now. Thanks for the reminder 👍 |
This is a stylistic tidying pulled out of review feedback from djc on #1718 - we want to avoid proliferating new
get_xxx
fns in this file, but there are so many existing usages that it would be a jarring inconsistency to change style for new fns.Instead, this branch fixes all of the existing instances in one go so that moving forward we can avoid the
get_
prefix while maintaining consistency. We already call out avoidingget_
prefixes in our style guide.