Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Next steps for Quinn support #1741

Closed
wants to merge 7 commits into from
Closed

Next steps for Quinn support #1741

wants to merge 7 commits into from

Conversation

djc
Copy link
Member

@djc djc commented Jan 12, 2024

This is based on rel-0.22 for now to facilitate testing Quinn -- can rebase to main before merge if we want to.

@rustls-benchmarking Rustls Benchmarking
Copy link

rustls-benchmarking bot commented Jan 12, 2024 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

There are no significant instruction count differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 4657605 4712536 54931 (1.18%) 3.16%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 4128221 4170615 42394 (1.03%) 4.06%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 8704646 8754311 49665 (0.57%) 0.93%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 12336258 12267889 -68369 (-0.55%) 1.01%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 12734629 12691533 -43096 (-0.34%) 0.94%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 12691221 12722107 30886 (0.24%) 0.71%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 8736514 8756180 19666 (0.23%) 1.29%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 31183565 31126704 -56861 (-0.18%) 0.47%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 33261291 33316804 55513 (0.17%) 0.42%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 30988093 30950966 -37127 (-0.12%) 0.45%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 31153627 31119962 -33665 (-0.11%) 0.30%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 57175087 57115684 -59403 (-0.10%) 0.33%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 57070683 57126706 56023 (0.10%) 0.27%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 33624397 33595041 -29356 (-0.09%) 0.49%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 33569522 33548368 -21154 (-0.06%) 0.60%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 57949753 57922120 -27633 (-0.05%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 91351345 91390167 38822 (0.04%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4860672 4862661 1989 (0.04%) 0.57%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3897470 3895910 -1560 (-0.04%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_server 4414253 4415947 1694 (0.04%) 0.53%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 30959512 30970512 11000 (0.04%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 30946692 30936485 -10207 (-0.03%) 0.35%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 13737658 13733565 -4093 (-0.03%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 33300545 33293025 -7520 (-0.02%) 0.46%
handshake_session_id_ring_1.3_ecdsap384_aes_server 43693861 43703712 9851 (0.02%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 43945975 43955769 9794 (0.02%) 0.21%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 2046701 2047060 359 (0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 33608855 33614644 5789 (0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 33584324 33590041 5717 (0.02%) 0.32%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 33312558 33318100 5542 (0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 33286075 33291600 5525 (0.02%) 0.30%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 33304470 33309985 5515 (0.02%) 0.21%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 33587050 33592264 5214 (0.02%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 2050127 2050445 318 (0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 33317093 33322216 5123 (0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 33569463 33574451 4988 (0.01%) 0.27%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 35453457 35448414 -5043 (-0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 57951004 57959037 8033 (0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 57947370 57955350 7980 (0.01%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 43953286 43959254 5968 (0.01%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 43687785 43693572 5787 (0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 43690567 43696212 5645 (0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 43913902 43919468 5566 (0.01%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 43621108 43626621 5513 (0.01%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 43993906 43999437 5531 (0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 43905412 43910909 5497 (0.01%) 0.25%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 43623999 43629382 5383 (0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 43627333 43632644 5311 (0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 43954632 43959793 5161 (0.01%) 0.26%
handshake_tickets_ring_1.3_ecdsap384_aes_client 42244923 42249849 4926 (0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 2132020 2132249 229 (0.01%) 0.21%
handshake_session_id_ring_1.3_ecdsap384_aes_client 42079940 42084354 4414 (0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92459987 92468798 8811 (0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3899866 3900237 371 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3392199 3391878 -321 (-0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 57082962 57087749 4787 (0.01%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92377193 92384876 7683 (0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 31166797 31169312 2515 (0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92373627 92380777 7150 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 3388573 3388327 -246 (-0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 42034158 42031356 -2802 (-0.01%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 4538124 4538426 302 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 3377039 3377254 215 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 4850646 4850954 308 (0.01%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4727737 4728030 293 (0.01%) 0.75%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 57086294 57089493 3199 (0.01%) 0.26%
transfer_no_resume_ring_1.2_rsa_aes_client 57833732 57836778 3046 (0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4533334 4533562 228 (0.01%) 0.98%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 31159995 31161485 1490 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92378652 92382885 4233 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 68447392 68450472 3080 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 57970337 57972827 2490 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 57966685 57969157 2472 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 91246261 91242606 -3655 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 57945613 57947836 2223 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 42207686 42209013 1327 (0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 42246833 42248107 1274 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 4175493 4175618 125 (0.00%) 0.93%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 2129432 2129493 61 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 4548204 4548074 -130 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 30989714 30988955 -759 (-0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 42082780 42083738 958 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4462743 4462836 93 (0.00%) 0.63%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92380471 92378559 -1912 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92433149 92434927 1778 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 31372361 31371816 -545 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 13741237 13741461 224 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 57083047 57083941 894 (0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 56953601 56954483 882 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 12241166 12241354 188 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 42031537 42030892 -645 (-0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 42437949 42437298 -651 (-0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 42208747 42208117 -630 (-0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 42262205 42261603 -602 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 35455965 35456422 457 (0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 12251210 12251366 156 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 91246250 91247264 1014 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 4441295 4441246 -49 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3395183 3395149 -34 (-0.00%) 0.28%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 57176697 57177256 559 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 31186733 31186447 -286 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 91346199 91346899 700 (0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 42400961 42400652 -309 (-0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 12046360 12046442 82 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 31359537 31359705 168 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 3173025 3173041 16 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 57177828 57178110 282 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 91367112 91367457 345 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 91252167 91252503 336 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 42213401 42213263 -138 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 4855600 4855604 4 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 31167790 31167796 6 (0.00%) 0.20%

Wall-time

Significant differences

⚠️ There are significant wall-time differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_ring_1.3_ecdsap384_aes 3.67 ms 3.60 ms ✅ -0.07 ms (-1.99%) 1.00%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.67 ms 3.60 ms ✅ -0.07 ms (-1.97%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_chacha 10.03 ms 9.91 ms ✅ -0.12 ms (-1.21%) 1.18%
handshake_session_id_ring_1.3_ecdsap384_aes 10.07 ms 9.95 ms ✅ -0.12 ms (-1.21%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_chacha 10.04 ms 9.92 ms ✅ -0.12 ms (-1.17%) 1.00%
handshake_tickets_ring_1.3_ecdsap384_aes 10.08 ms 9.97 ms ✅ -0.11 ms (-1.07%) 1.00%

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.89 ms 5.02 ms 0.13 ms (2.69%) 7.05%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.64 ms 5.79 ms 0.14 ms (2.53%) 5.60%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.82 ms 5.96 ms 0.14 ms (2.45%) 3.26%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.82 ms 5.96 ms 0.14 ms (2.32%) 4.46%
transfer_no_resume_ring_1.3_ecdsap256_aes 6.66 ms 6.80 ms 0.14 ms (2.06%) 3.60%
transfer_no_resume_ring_1.2_rsa_aes 7.16 ms 7.31 ms 0.14 ms (2.02%) 2.60%
transfer_no_resume_ring_1.3_rsa_aes 7.24 ms 7.38 ms 0.14 ms (1.91%) 3.30%
handshake_tickets_ring_1.2_rsa_aes 1.78 ms 1.81 ms 0.03 ms (1.42%) 1.54%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 481.29 µs 487.90 µs 6.61 µs (1.37%) 3.78%
transfer_no_resume_ring_1.3_ecdsap256_chacha 13.36 ms 13.52 ms 0.15 ms (1.16%) 1.96%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 14.10 ms 14.26 ms 0.16 ms (1.10%) 2.19%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 13.36 ms 13.51 ms 0.14 ms (1.08%) 2.29%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 483.72 µs 488.76 µs 5.04 µs (1.04%) 3.35%
transfer_no_resume_ring_1.3_rsa_chacha 13.96 ms 14.10 ms 0.14 ms (0.98%) 2.08%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 2.24 ms 2.27 ms 0.02 ms (0.97%) 1.56%
handshake_no_resume_ring_1.3_ecdsap256_aes 505.04 µs 509.91 µs 4.87 µs (0.96%) 2.32%
handshake_session_id_ring_1.2_rsa_aes 1.70 ms 1.72 ms 0.02 ms (0.93%) 1.56%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 14.31 ms 14.43 ms 0.13 ms (0.89%) 1.72%
handshake_no_resume_ring_1.3_ecdsap256_chacha 503.72 µs 507.73 µs 4.00 µs (0.79%) 2.26%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 5.35 ms 5.39 ms 0.04 ms (0.74%) 2.24%
handshake_session_id_ring_1.3_ecdsap256_chacha 6.88 ms 6.83 ms -0.05 ms (-0.72%) 1.21%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 6.34 ms 6.38 ms 0.04 ms (0.70%) 1.92%
transfer_no_resume_ring_1.3_ecdsap384_aes 9.83 ms 9.89 ms 0.06 ms (0.64%) 2.08%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 5.39 ms 5.43 ms 0.03 ms (0.64%) 2.49%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 6.10 ms 6.14 ms 0.04 ms (0.62%) 2.19%
handshake_tickets_ring_1.3_rsa_chacha 7.51 ms 7.47 ms -0.04 ms (-0.59%) 1.11%
handshake_no_resume_ring_1.3_rsa_chacha 1.08 ms 1.09 ms 0.01 ms (0.59%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_chacha 6.88 ms 6.84 ms -0.04 ms (-0.59%) 1.26%
handshake_session_id_ring_1.3_ecdsap256_aes 6.91 ms 6.87 ms -0.04 ms (-0.57%) 1.22%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 6.37 ms 6.40 ms 0.04 ms (0.56%) 2.03%
handshake_session_id_ring_1.3_rsa_chacha 7.50 ms 7.46 ms -0.04 ms (-0.54%) 1.23%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.22 ms 1.23 ms 0.01 ms (0.53%) 1.35%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 2.07 ms 2.08 ms 0.01 ms (0.52%) 1.00%
handshake_tickets_ring_1.3_ecdsap256_aes 6.91 ms 6.88 ms -0.04 ms (-0.51%) 1.07%
handshake_no_resume_ring_1.3_rsa_aes 1.08 ms 1.09 ms 0.01 ms (0.51%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 6.15 ms 6.18 ms 0.03 ms (0.49%) 1.91%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 6.32 ms 6.35 ms 0.03 ms (0.49%) 1.23%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.34 ms 1.35 ms 0.01 ms (0.49%) 1.47%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 5.34 ms 5.37 ms 0.03 ms (0.48%) 1.71%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 6.08 ms 6.10 ms 0.03 ms (0.44%) 1.40%
handshake_no_resume_ring_1.2_rsa_aes 1.07 ms 1.07 ms 0.00 ms (0.41%) 1.15%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.55 ms 16.61 ms 0.07 ms (0.40%) 1.71%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.39 ms 1.40 ms 0.01 ms (0.40%) 1.00%
handshake_session_id_ring_1.3_rsa_aes 7.54 ms 7.51 ms -0.03 ms (-0.39%) 1.00%
handshake_tickets_ring_1.3_rsa_aes 7.55 ms 7.52 ms -0.03 ms (-0.36%) 1.09%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 6.35 ms 6.37 ms 0.02 ms (0.34%) 1.87%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 5.37 ms 5.39 ms 0.02 ms (0.34%) 2.43%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.23 ms 1.23 ms 0.00 ms (0.33%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.40 ms 1.41 ms 0.00 ms (0.31%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 6.11 ms 6.13 ms 0.02 ms (0.28%) 1.90%

Additional information

Historical results

Checkout details:

@codecov Codecov
Copy link

codecov bot commented Jan 12, 2024 •
edited
Loading

Codecov Report

Attention: 37 lines in your changes are missing coverage. Please review.

Comparison is base (5cd41a3) 96.28% compared to head (ca9cdfc) 96.10%.

Files Patch % Lines
rustls/src/quic.rs 0.00% 25 Missing ⚠️
rustls/src/crypto/ring/quic.rs 75.00% 6 Missing ⚠️
rustls/src/client/client_conn.rs 0.00% 3 Missing ⚠️
rustls/src/server/server_conn.rs 0.00% 3 Missing ⚠️
Additional details and impacted files 
@@             Coverage Diff              @@
##           rel-0.22    #1741      +/-   ##
============================================
- Coverage     96.28%   96.10%   -0.18%     
============================================
  Files            79       79              
  Lines         16845    16902      +57     
============================================
+ Hits          16219    16244      +25     
- Misses          626      658      +32

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

ctz
ctz reviewed Jan 12, 2024
View reviewed changes
rustls/src/crypto/aws_lc_rs/tls13.rs Show resolved Hide resolved
rustls/src/quic.rs Show resolved Hide resolved
djc
djc commented Jan 12, 2024
View reviewed changes
rustls/src/quic.rs Outdated Show resolved Hide resolved
cpu
cpu reviewed Jan 12, 2024
View reviewed changes
rustls/src/quic.rs Outdated Show resolved Hide resolved
@junkurihara junkurihara mentioned this pull request Jan 12, 2024
Closed
6 tasks
@djc djc force-pushed the quic-support branch 3 times, most recently from 5f067d9 to aef485d Compare January 24, 2024 21:16
@djc djc marked this pull request as ready for review January 24, 2024 21:58
@djc
Copy link
Member Author

djc commented Jan 24, 2024

Since I have quinn-proto compiling now, marking this as ready for review.

ctz
ctz approved these changes Jan 25, 2024
View reviewed changes
Copy link
Member

@ctz ctz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, modulo the questions about breaking changes.

cpu
cpu reviewed Jan 25, 2024
View reviewed changes
rustls/src/quic.rs Show resolved Hide resolved
rustls/src/client/client_conn.rs Show resolved Hide resolved
@Icelk Icelk mentioned this pull request Feb 4, 2024
Closed
@cpu cpu mentioned this pull request Feb 8, 2024
Closed
8 tasks
@cpu cpu mentioned this pull request Feb 20, 2024
Merged
@djc
Copy link
Member Author

djc commented Feb 21, 2024

Going to close this, let's continue discussion in #1798.

@djc djc closed this Feb 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpu cpu cpu left review comments

@ctz ctz ctz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@djc @cpu @ctz