-
Notifications
You must be signed in to change notification settings - Fork 619
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
github actions: standardise on ubuntu-latest #1773
Conversation
Benchmark resultsInstruction countsSignificant differencesThere are no significant instruction count differences Other differencesClick to expand
Wall-timeSignificant differencesThere are no significant wall-time differences Other differencesClick to expand
Additional informationCheckout details:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd like to have just one, so I can use act locally to do test builds without having multiple docker images.
Ah neat, I hadn't heard of this tool before: https://github.com/nektos/act
Yeah this mostly works for me -- you need to opt into the "full" images (which are 40-50GB, because they contain every version of every language runtime available). Though our "Check cross compilation targets" job because it's trying to use docker nested inside a docker container. But the remainder work. |
Have updated the branch protection rules for this. |
Prior to this we had a mix of ubuntu-20.04 and ubuntu-latest. I'd like to have just one, so I can use
act
locally to do test builds without having multiple docker images.This will probably trip up the branch protection rules.