ci: add Windows aws-lc-rs build reqs to daily-tests

[cpu]

Fixes daily test failures for the Windows builds that are failing with:

-- The ASM_NASM compiler identification is unknown
-- Didn't find assembler

[cpu]

Here's a manual run on my fork showing the daily tests jobs are now green.

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (8e4afc6) 95.94% compared to head (5308abd) 95.94%.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1786   +/-   ##
=======================================
  Coverage   95.94%   95.94%           
=======================================
  Files          81       81           
  Lines       18590    18590           
=======================================
  Hits        17837    17837           
  Misses        753      753           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[ctz]

Oddly I don't get email notifications when this workflow fails. Hmm.

[cpu]

Oddly I don't get email notifications when this workflow fails. Hmm.

The last time I looked into this it was sending notifications to whoever happened to modify the job last (which I thought would be you in #1773 but 🤷) - I try to keep my forks synchronized and seem to get notifications consistently from the fork that way.

It's not ideal :-( The only idea I have is to set up a webhook that pushes the failures to a bot channel in Discord.

[rustls-benchmarking]

Benchmark results

Instruction counts

Significant differences

There are no significant instruction count differences

Other differences

Click to expand

Scenario	Baseline	Candidate	Diff	Threshold
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server	4032694	4101808	69114 (1.71%)	4.27%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server	4593966	4633109	39143 (0.85%)	2.53%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client	4236772	4219285	-17487 (-0.41%)	1.01%
handshake_session_id_ring_1.2_rsa_aes_client	4456946	4471901	14955 (0.34%)	0.55%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client	8671034	8646829	-24205 (-0.28%)	0.97%
handshake_tickets_ring_1.2_rsa_aes_server	4828492	4839488	10996 (0.23%)	0.59%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server	12301376	12277255	-24121 (-0.20%)	1.25%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server	32656633	32604199	-52434 (-0.16%)	0.45%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client	8672036	8685515	13479 (0.16%)	1.29%
handshake_session_id_ring_1.2_rsa_aes_server	4367387	4373161	5774 (0.13%)	0.47%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client	4555649	4549675	-5974 (-0.13%)	1.08%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server	32672759	32630954	-41805 (-0.13%)	0.52%
handshake_tickets_ring_1.3_ecdsap256_aes_server	43837259	43890927	53668 (0.12%)	0.26%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client	30312664	30339502	26838 (0.09%)	0.38%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client	3346744	3343869	-2875 (-0.09%)	0.22%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server	57136379	57184117	47738 (0.08%)	0.30%
handshake_tickets_ring_1.3_ecdsap384_chacha_server	43814769	43779780	-34989 (-0.08%)	0.26%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server	57137647	57179321	41674 (0.07%)	0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server	57137926	57178593	40667 (0.07%)	0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client	3898846	3896582	-2264 (-0.06%)	0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client	57964590	57997569	32979 (0.06%)	0.20%
handshake_tickets_ring_1.3_rsa_aes_client	42370423	42346761	-23662 (-0.06%)	0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server	32881800	32899943	18143 (0.06%)	0.58%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server	32632310	32649744	17434 (0.05%)	0.20%
handshake_session_id_ring_1.3_rsa_aes_client	42183516	42204556	21040 (0.05%)	0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server	2131851	2130792	-1059 (-0.05%)	0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server	12705596	12699760	-5836 (-0.05%)	0.97%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server	91257054	91294667	37613 (0.04%)	0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server	32833334	32819904	-13430 (-0.04%)	0.32%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server	32866303	32853011	-13292 (-0.04%)	0.22%
handshake_no_resume_ring_1.3_ecdsap256_aes_server	2128269	2129129	860 (0.04%)	0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client	3342756	3341433	-1323 (-0.04%)	0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server	32610247	32622534	12287 (0.04%)	0.30%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client	92446735	92413672	-33063 (-0.04%)	0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server	32621370	32609815	-11555 (-0.04%)	0.21%
handshake_session_id_ring_1.3_rsa_chacha_client	42131459	42144272	12813 (0.03%)	0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client	30288179	30297308	9129 (0.03%)	0.42%
handshake_no_resume_ring_1.3_ecdsap384_aes_server	13732569	13736581	4012 (0.03%)	0.20%
handshake_tickets_ring_1.3_rsa_aes_server	43927451	43914887	-12564 (-0.03%)	0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server	32867983	32877349	9366 (0.03%)	0.60%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client	30521531	30529211	7680 (0.03%)	0.54%
handshake_session_id_ring_1.3_ecdsap384_aes_client	42011430	42001181	-10249 (-0.02%)	0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server	57157028	57170438	13410 (0.02%)	0.38%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server	32653447	32646816	-6631 (-0.02%)	0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server	43663214	43655236	-7978 (-0.02%)	0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client	30487284	30492823	5539 (0.02%)	0.34%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server	4261171	4260460	-711 (-0.02%)	0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client	30697906	30693004	-4902 (-0.02%)	0.22%
handshake_session_id_ring_1.3_rsa_aes_server	43667955	43661072	-6883 (-0.02%)	0.20%
handshake_tickets_ring_1.2_rsa_aes_client	4735906	4735164	-742 (-0.02%)	0.75%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server	32831006	32826715	-4291 (-0.01%)	0.26%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client	3356705	3356267	-438 (-0.01%)	0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client	30298147	30302074	3927 (0.01%)	0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server	4359612	43590540	-5583 (-0.01%)	0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client	35446970	35451146	4176 (0.01%)	0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client	42180218	42175398	-4820 (-0.01%)	0.20%
handshake_tickets_ring_1.3_rsa_chacha_server	43897069	43892101	-4968 (-0.01%)	0.20%
handshake_tickets_ring_1.3_rsa_chacha_client	42327811	42332574	4763 (0.01%)	0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client	41956452	41951970	-4482 (-0.01%)	0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server	91247857	91256942	9085 (0.01%)	0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server	12688466	12689715	1249 (0.01%)	0.70%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server	1885689	1885864	175 (0.01%)	0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server	43587549	43591548	3999 (0.01%)	0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client	41952433	41956212	3779 (0.01%)	0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client	41993709	41997073	3364 (0.01%)	0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client	4547955	4547601	-354 (-0.01%)	0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server	43836816	43840083	3267 (0.01%)	0.23%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client	30704750	30702637	-2113 (-0.01%)	0.20%
handshake_no_resume_ring_1.3_rsa_aes_client	4538011	4537706	-305 (-0.01%)	0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client	3153675	3153475	-200 (-0.01%)	0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client	42140196	42137580	-2616 (-0.01%)	0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server	4265288	4265040	-248 (-0.01%)	0.20%
handshake_session_id_ring_1.3_rsa_chacha_server	43586532	43588861	2329 (0.01%)	0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client	92380959	92385353	4394 (0.00%)	0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client	42140030	42138135	-1895 (-0.00%)	0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server	43891580	43889639	-1941 (-0.00%)	0.21%
handshake_tickets_ring_1.3_ecdsap384_aes_client	42180464	42178618	-1846 (-0.00%)	0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client	57968451	57970645	2194 (0.00%)	0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server	32852735	32851503	-1232 (-0.00%)	0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client	30507108	30505986	-1122 (-0.00%)	0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client	92437002	92440230	3228 (0.00%)	0.20%
handshake_no_resume_ring_1.3_rsa_aes_server	12240112	12239690	-422 (-0.00%)	0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server	57091054	57089237	-1817 (-0.00%)	0.26%
handshake_no_resume_ring_1.2_rsa_aes_client	4441525	4441391	-134 (-0.00%)	0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server	43666192	43667428	1236 (0.00%)	0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server	91349110	91346561	-2549 (-0.00%)	0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client	30491280	30492095	815 (0.00%)	0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server	12250211	12249913	-298 (-0.00%)	0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server	13740541	13740236	-305 (-0.00%)	0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client	30328137	30327470	-667 (-0.00%)	0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client	30505914	30506505	591 (0.00%)	0.24%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server	91366509	91364754	-1755 (-0.00%)	0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client	92448475	92450089	1614 (0.00%)	0.20%
transfer_no_resume_ring_1.2_rsa_aes_server	56972990	56972022	-968 (-0.00%)	0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client	3367442	3367493	51 (0.00%)	0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server	1882466	1882493	27 (0.00%)	0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client	30483254	30482830	-424 (-0.00%)	0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client	92390745	92391985	1240 (0.00%)	0.20%
transfer_no_resume_ring_1.2_rsa_aes_client	57810965	57811510	545 (0.00%)	0.20%
transfer_no_resume_ring_1.3_rsa_aes_server	57088139	57087670	-469 (-0.00%)	0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client	57948685	57948275	-410 (-0.00%)	0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server	91348398	91347811	-587 (-0.00%)	0.20%
handshake_no_resume_ring_1.2_rsa_aes_server	12045955	12046020	65 (0.00%)	0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client	92385299	92385724	425 (0.00%)	0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client	57949897	57950127	230 (0.00%)	0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client	35454362	35454233	-129 (-0.00%)	0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client	57989202	57989406	204 (0.00%)	0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_client	3896630	3896618	-12 (-0.00%)	0.21%
transfer_no_resume_ring_1.3_ecdsap384_aes_server	57108391	57108545	154 (0.00%)	0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client	68431935	68432098	163 (0.00%)	0.20%
transfer_no_resume_ring_1.3_rsa_aes_client	57950143	57950037	-106 (-0.00%)	0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server	91251888	91251871	-17 (-0.00%)	0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand

Scenario	Baseline	Candidate	Diff	Threshold
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes	4.89 ms	4.85 ms	-0.05 ms (-0.94%)	7.34%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes	5.62 ms	5.56 ms	-0.05 ms (-0.93%)	6.90%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha	477.74 µs	473.57 µs	-4.17 µs (-0.87%)	3.91%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes	477.82 µs	473.67 µs	-4.15 µs (-0.87%)	3.88%
transfer_no_resume_ring_1.3_ecdsap256_aes	6.69 ms	6.63 ms	-0.05 ms (-0.79%)	4.34%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes	5.84 ms	5.80 ms	-0.04 ms (-0.71%)	3.26%
handshake_tickets_aws_lc_rs_1.2_rsa_aes	2.36 ms	2.34 ms	-0.02 ms (-0.70%)	1.90%
handshake_no_resume_ring_1.3_ecdsap256_aes	507.78 µs	504.68 µs	-3.10 µs (-0.61%)	2.32%
handshake_session_id_aws_lc_rs_1.2_rsa_aes	2.19 ms	2.18 ms	-0.01 ms (-0.61%)	1.00%
transfer_no_resume_ring_1.3_ecdsap384_aes	9.79 ms	9.74 ms	-0.06 ms (-0.59%)	2.11%
transfer_no_resume_ring_1.2_rsa_aes	7.19 ms	7.15 ms	-0.04 ms (-0.56%)	2.60%
handshake_tickets_ring_1.2_rsa_aes	1.84 ms	1.83 ms	-0.01 ms (-0.42%)	1.54%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha	6.39 ms	6.36 ms	-0.03 ms (-0.40%)	1.96%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes	5.84 ms	5.82 ms	-0.02 ms (-0.39%)	4.46%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes	6.11 ms	6.09 ms	-0.02 ms (-0.37%)	1.91%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha	14.10 ms	14.05 ms	-0.05 ms (-0.36%)	2.64%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes	5.37 ms	5.35 ms	-0.02 ms (-0.36%)	2.41%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes	5.39 ms	5.37 ms	-0.02 ms (-0.35%)	2.42%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha	5.39 ms	5.37 ms	-0.02 ms (-0.35%)	2.23%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha	13.39 ms	13.34 ms	-0.05 ms (-0.34%)	2.61%
handshake_tickets_aws_lc_rs_1.3_rsa_aes	6.38 ms	6.36 ms	-0.02 ms (-0.32%)	2.09%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha	14.34 ms	14.29 ms	-0.05 ms (-0.32%)	1.73%
transfer_no_resume_ring_1.3_rsa_chacha	13.98 ms	13.94 ms	-0.04 ms (-0.32%)	1.87%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha	5.36 ms	5.34 ms	-0.02 ms (-0.31%)	1.65%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha	6.10 ms	6.08 ms	-0.02 ms (-0.31%)	1.92%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha	6.36 ms	6.34 ms	-0.02 ms (-0.30%)	1.50%
transfer_no_resume_ring_1.3_ecdsap384_chacha	16.49 ms	16.44 ms	-0.05 ms (-0.30%)	1.71%
transfer_no_resume_ring_1.3_ecdsap256_chacha	13.39 ms	13.35 ms	-0.04 ms (-0.30%)	2.27%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha	6.06 ms	6.04 ms	-0.02 ms (-0.30%)	1.40%
handshake_tickets_ring_1.3_ecdsap256_chacha	6.85 ms	6.83 ms	-0.02 ms (-0.28%)	1.48%
handshake_no_resume_ring_1.3_ecdsap256_chacha	505.93 µs	504.50 µs	-1.43 µs (-0.28%)	2.68%
transfer_no_resume_ring_1.3_rsa_aes	7.27 ms	7.25 ms	-0.02 ms (-0.28%)	3.34%
handshake_session_id_aws_lc_rs_1.3_rsa_aes	6.38 ms	6.36 ms	-0.02 ms (-0.28%)	2.27%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes	6.08 ms	6.07 ms	-0.02 ms (-0.28%)	2.33%
handshake_tickets_ring_1.3_rsa_chacha	7.48 ms	7.46 ms	-0.02 ms (-0.27%)	1.14%
handshake_session_id_ring_1.3_ecdsap256_aes	6.87 ms	6.86 ms	-0.02 ms (-0.26%)	1.25%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes	1.36 ms	1.36 ms	-0.00 ms (-0.25%)	1.64%
handshake_no_resume_ring_1.3_rsa_chacha	1.09 ms	1.08 ms	-0.00 ms (-0.25%)	1.00%
handshake_session_id_ring_1.3_ecdsap256_chacha	6.84 ms	6.82 ms	-0.02 ms (-0.24%)	1.49%
handshake_session_id_ring_1.3_rsa_chacha	7.47 ms	7.45 ms	-0.02 ms (-0.23%)	1.42%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha	1.18 ms	1.18 ms	-0.00 ms (-0.23%)	1.53%
handshake_tickets_ring_1.3_rsa_aes	7.52 ms	7.51 ms	-0.02 ms (-0.22%)	1.16%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes	1.19 ms	1.19 ms	-0.00 ms (-0.21%)	1.00%
handshake_session_id_ring_1.3_rsa_aes	7.51 ms	7.50 ms	-0.02 ms (-0.20%)	1.17%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes	1.42 ms	1.41 ms	-0.00 ms (-0.20%)	1.02%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha	1.41 ms	1.40 ms	-0.00 ms (-0.19%)	1.00%
handshake_tickets_ring_1.3_ecdsap256_aes	6.89 ms	6.87 ms	-0.01 ms (-0.19%)	1.28%
handshake_tickets_ring_1.3_ecdsap384_aes	9.99 ms	9.97 ms	-0.02 ms (-0.15%)	1.00%
handshake_no_resume_ring_1.3_rsa_aes	1.08 ms	1.08 ms	-0.00 ms (-0.15%)	1.16%
handshake_no_resume_ring_1.2_rsa_aes	1.07 ms	1.07 ms	-0.00 ms (-0.14%)	1.16%
handshake_session_id_ring_1.3_ecdsap384_chacha	9.94 ms	9.92 ms	-0.01 ms (-0.14%)	1.20%
handshake_tickets_ring_1.3_ecdsap384_chacha	9.95 ms	9.94 ms	-0.01 ms (-0.13%)	1.00%
handshake_session_id_ring_1.3_ecdsap384_aes	9.96 ms	9.95 ms	-0.01 ms (-0.12%)	1.00%
handshake_session_id_ring_1.2_rsa_aes	1.75 ms	1.75 ms	-0.00 ms (-0.08%)	2.00%
handshake_no_resume_ring_1.3_ecdsap384_aes	3.61 ms	3.61 ms	-0.00 ms (-0.03%)	1.00%
handshake_no_resume_ring_1.3_ecdsap384_chacha	3.61 ms	3.61 ms	0.00 ms (0.03%)	1.00%

Additional information

Historical results

Checkout details:

• Base repo: https://github.com/rustls/rustls.git
• Base branch: main (8e4afc6)
• Candidate repo: https://github.com/cpu/rustls.git
• Candidate branch: cpu-fix-daily-tests (5308abd)