Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docs.rs build #1827

Merged
merged 2 commits into from
Mar 1, 2024
Merged

Fix docs.rs build #1827

merged 2 commits into from
Mar 1, 2024

Conversation

ctz
Copy link
Member

@ctz ctz commented Mar 1, 2024

See rust-lang/docs.rs#1303: docs.rs's build environment has a golang package but doesn't set the environment variables needed to make it usable.

This PR avoids that by not generating docs with the fips feature, and then directly addressing the one API item we have under the fips feature.

fixes #1826

ctz added 2 commits March 1, 2024 10:28
@ctz
Avoid fips feature for docs.rs
005afd8 
The docs.rs environment has golang installed, but doesn't have
the environment variables needed to make it actually work:
rust-lang/docs.rs#1303

So avoid that entirely.
@ctz
default_fips_provider(): make visible in docs
3e88563
@codecov Codecov
Copy link

codecov bot commented Mar 1, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.83%. Comparing base (eb0791b) to head (3e88563).
Report is 2 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #1827   +/-   ##
=======================================
  Coverage   95.83%   95.83%           
=======================================
  Files          84       84           
  Lines       18861    18879   +18     
=======================================
+ Hits        18075    18093   +18     
  Misses        786      786

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rustls-benchmarking Rustls Benchmarking
Copy link

rustls-benchmarking bot commented Mar 1, 2024 •
edited
Loading

Benchmark results

Instruction counts

Significant differences

There are no significant instruction count differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 4069733 4012633 -57100 (-1.40%) 3.67%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 8685433 8655419 -30014 (-0.35%) 0.68%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 4524245 4509713 -14532 (-0.32%) 3.00%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 12292753 12322553 29800 (0.24%) 1.11%
handshake_tickets_ring_1.2_rsa_aes_client 4717575 4706838 -10737 (-0.23%) 0.81%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 8654429 8669473 15044 (0.17%) 0.89%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 32607160 32657312 50152 (0.15%) 0.40%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 30485732 30439994 -45738 (-0.15%) 0.52%
handshake_session_id_ring_1.2_rsa_aes_server 4330056 4323739 -6317 (-0.15%) 0.52%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 30250353 30291945 41592 (0.14%) 0.41%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 32648746 32688927 40181 (0.12%) 0.64%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 32406897 32446432 39535 (0.12%) 0.52%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 12711899 12700417 -11482 (-0.09%) 0.82%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 32619772 32648501 28729 (0.09%) 0.27%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3344535 3342207 -2328 (-0.07%) 0.23%
handshake_tickets_ring_1.3_rsa_aes_client 42408548 42383557 -24991 (-0.06%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3897103 3894828 -2275 (-0.06%) 0.28%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 32478999 32460548 -18451 (-0.06%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 30303749 30287057 -16692 (-0.06%) 0.49%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 43666322 43689762 23440 (0.05%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 30420899 30436974 16075 (0.05%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 30298658 30282967 -15691 (-0.05%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 30431905 30446529 14624 (0.05%) 0.28%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 32414885 32429474 14589 (0.05%) 0.50%
handshake_session_id_ring_1.3_rsa_aes_client 42221636 42203096 -18540 (-0.04%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 30493330 30480333 -12997 (-0.04%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4442783 4440909 -1874 (-0.04%) 0.78%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 12697055 12702035 4980 (0.04%) 0.90%
handshake_tickets_ring_1.3_ecdsap384_aes_server 43739727 43723519 -16208 (-0.04%) 0.21%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 4183184 4184705 1521 (0.04%) 0.90%
handshake_session_id_ring_1.3_rsa_chacha_client 42122661 42137825 15164 (0.04%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 4258594 4257064 -1530 (-0.04%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 42329064 42316309 -12755 (-0.03%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46254057 46240796 -13261 (-0.03%) 0.39%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 30252482 30261087 8605 (0.03%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 32653148 32645226 -7922 (-0.02%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80447383 80428729 -18654 (-0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 30454016 30461041 7025 (0.02%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 43548081 43538445 -9636 (-0.02%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client 42005392 41996906 -8486 (-0.02%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 43444788 43453489 8701 (0.02%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 42167684 42159533 -8151 (-0.02%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46264363 46255651 -8712 (-0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 32436844 32442837 5993 (0.02%) 0.30%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4521946 4522778 832 (0.02%) 0.76%
handshake_tickets_ring_1.3_ecdsap256_aes_server 43728110 43735988 7878 (0.02%) 0.28%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 32467562 32473280 5718 (0.02%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 42181501 42174535 -6966 (-0.02%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 32637225 32631886 -5339 (-0.02%) 0.32%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 43660690 43667393 6703 (0.02%) 0.21%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 30453256 30448591 -4665 (-0.02%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 43799253 43792650 -6603 (-0.02%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 42115663 42109316 -6347 (-0.02%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 4547701 4547027 -674 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 30672574 30677097 4523 (0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80343757 80355280 11523 (0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 2126520 2126218 -302 (-0.01%) 0.35%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 32659067 32663502 4435 (0.01%) 0.21%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 3151832 3151450 -382 (-0.01%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_server 4764071 4764626 555 (0.01%) 0.50%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80357636 80349098 -8538 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 30669445 30666353 -3092 (-0.01%) 0.21%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1879002 1878818 -184 (-0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 57983498 57978076 -5422 (-0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46297617 46301908 4291 (0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92428267 92436584 8317 (0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 41925716 41922024 -3692 (-0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46192896 46189151 -3745 (-0.01%) 0.30%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58059482 58064022 4540 (0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3897380 3897677 297 (0.01%) 0.21%
handshake_session_id_ring_1.3_ecdsap384_aes_client 42007918 42010890 2972 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 3366377 3366172 -205 (-0.01%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_server 43439384 43441968 2584 (0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 43439943 43437370 -2573 (-0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 41923722 41926183 2461 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 3355383 3355566 183 (0.01%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 4538015 4537773 -242 (-0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 32450405 32448791 -1614 (-0.00%) 0.23%
handshake_session_id_ring_1.3_ecdsap384_aes_server 43542296 43544432 2136 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 4262435 4262237 -198 (-0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 42096914 42098844 1930 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 2126611 2126704 93 (0.00%) 0.38%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92395140 92399046 3906 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 13734941 13734417 -524 (-0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 43539454 43541046 1592 (0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3340738 3340637 -101 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92430299 92428759 -1540 (-0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 43714096 43714786 690 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 35452822 35452272 -550 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 13737300 13737104 -196 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58064154 58064884 730 (0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 12042358 12042210 -148 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_server 12237383 12237236 -147 (-0.00%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1882507 1882528 21 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 35455015 35454670 -345 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46265567 46265963 396 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58064889 58064444 -445 (-0.00%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 4440199 4440168 -31 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46176617 46176313 -304 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80445449 80444921 -528 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 12246758 12246679 -79 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 68385830 68386270 440 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client 92398423 92398953 530 (0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46293853 46293599 -254 (-0.00%) 0.25%
transfer_no_resume_ring_1.3_rsa_aes_server 46290274 46290031 -243 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 57966619 57966376 -243 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80455820 80456069 249 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80343317 80343078 -239 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 57986372 57986235 -137 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92397299 92397183 -116 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 57920477 57920547 70 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92455818 92455867 49 (0.00%) 0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_no_resume_ring_1.3_ecdsap256_aes 507.46 µs 509.40 µs 1.93 µs (0.38%) 2.17%
handshake_no_resume_ring_1.3_ecdsap256_chacha 507.69 µs 506.33 µs -1.36 µs (-0.27%) 2.70%
handshake_no_resume_ring_1.3_rsa_aes 1.08 ms 1.08 ms 0.00 ms (0.22%) 1.02%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 475.99 µs 474.97 µs -1.02 µs (-0.21%) 2.72%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.73 ms 5.72 ms -0.01 ms (-0.20%) 3.61%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 6.35 ms 6.34 ms -0.01 ms (-0.16%) 2.11%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 6.06 ms 6.05 ms -0.01 ms (-0.14%) 1.93%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 5.37 ms 5.37 ms -0.01 ms (-0.12%) 2.26%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.38 ms 16.40 ms 0.02 ms (0.12%) 1.55%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 6.09 ms 6.08 ms -0.01 ms (-0.12%) 1.70%
handshake_session_id_ring_1.3_ecdsap384_aes 9.99 ms 10.00 ms 0.01 ms (0.11%) 1.49%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.98 ms 13.99 ms 0.02 ms (0.11%) 1.76%
handshake_session_id_ring_1.3_rsa_aes 7.53 ms 7.54 ms 0.01 ms (0.11%) 1.61%
handshake_session_id_ring_1.2_rsa_aes 1.75 ms 1.75 ms -0.00 ms (-0.11%) 2.42%
transfer_no_resume_ring_1.3_ecdsap384_aes 9.72 ms 9.73 ms 0.01 ms (0.11%) 2.66%
transfer_no_resume_ring_1.3_ecdsap256_aes 6.62 ms 6.62 ms 0.01 ms (0.11%) 3.52%
handshake_session_id_ring_1.3_ecdsap384_chacha 9.95 ms 9.96 ms 0.01 ms (0.10%) 1.47%
transfer_no_resume_ring_1.3_ecdsap256_chacha 13.28 ms 13.29 ms 0.01 ms (0.10%) 1.84%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 13.28 ms 13.29 ms 0.01 ms (0.10%) 1.53%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.19 ms 1.19 ms -0.00 ms (-0.10%) 1.15%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 6.37 ms 6.36 ms -0.01 ms (-0.10%) 1.89%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 5.34 ms 5.34 ms -0.01 ms (-0.09%) 1.99%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 6.35 ms 6.34 ms -0.01 ms (-0.09%) 1.79%
transfer_no_resume_ring_1.3_rsa_chacha 13.86 ms 13.87 ms 0.01 ms (0.09%) 1.59%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.74 ms 5.74 ms -0.01 ms (-0.09%) 3.84%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 14.21 ms 14.22 ms 0.01 ms (0.09%) 1.45%
handshake_session_id_ring_1.3_ecdsap256_aes 6.89 ms 6.89 ms 0.01 ms (0.08%) 1.78%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.41 ms 1.41 ms 0.00 ms (0.08%) 1.00%
transfer_no_resume_ring_1.3_rsa_aes 7.19 ms 7.20 ms 0.01 ms (0.08%) 2.75%
handshake_tickets_ring_1.3_rsa_aes 7.55 ms 7.56 ms 0.01 ms (0.07%) 1.60%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 6.04 ms 6.04 ms -0.00 ms (-0.07%) 1.83%
transfer_no_resume_ring_1.2_rsa_aes 7.09 ms 7.09 ms 0.00 ms (0.07%) 2.76%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.18 ms 1.18 ms 0.00 ms (0.07%) 1.15%
handshake_tickets_ring_1.3_ecdsap256_chacha 6.85 ms 6.86 ms 0.00 ms (0.06%) 2.03%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 476.17 µs 475.90 µs -0.27 µs (-0.06%) 2.42%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.80 ms 4.80 ms -0.00 ms (-0.06%) 4.55%
handshake_tickets_ring_1.3_ecdsap256_aes 6.90 ms 6.91 ms 0.00 ms (0.05%) 1.94%
handshake_tickets_ring_1.3_ecdsap384_aes 10.01 ms 10.02 ms 0.01 ms (0.05%) 1.50%
handshake_session_id_ring_1.3_rsa_chacha 7.48 ms 7.49 ms 0.00 ms (0.05%) 2.03%
handshake_no_resume_ring_1.2_rsa_aes 1.07 ms 1.07 ms -0.00 ms (-0.05%) 1.05%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 2.32 ms 2.32 ms 0.00 ms (0.05%) 1.73%
handshake_tickets_ring_1.3_ecdsap384_chacha 9.97 ms 9.97 ms 0.00 ms (0.05%) 1.80%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.40 ms 1.41 ms 0.00 ms (0.04%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 6.09 ms 6.08 ms -0.00 ms (-0.03%) 2.01%
handshake_no_resume_ring_1.3_rsa_chacha 1.09 ms 1.09 ms -0.00 ms (-0.03%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 5.38 ms 5.38 ms 0.00 ms (0.03%) 2.52%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 5.34 ms 5.34 ms -0.00 ms (-0.02%) 2.29%
handshake_session_id_ring_1.3_ecdsap256_chacha 6.85 ms 6.85 ms 0.00 ms (0.02%) 1.75%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.36 ms 1.36 ms 0.00 ms (0.02%) 1.01%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 2.17 ms 2.17 ms 0.00 ms (0.02%) 1.54%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.62 ms 3.62 ms -0.00 ms (-0.02%) 1.34%
handshake_tickets_ring_1.2_rsa_aes 1.84 ms 1.84 ms 0.00 ms (0.01%) 1.60%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.62 ms 3.62 ms -0.00 ms (-0.01%) 1.36%
handshake_tickets_ring_1.3_rsa_chacha 7.50 ms 7.50 ms 0.00 ms (0.01%) 1.96%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 6.37 ms 6.37 ms 0.00 ms (0.00%) 2.19%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.51 ms 5.51 ms -0.00 ms (-0.00%) 3.90%

Additional information

Historical results

Checkout details:

cpu
cpu approved these changes Mar 1, 2024
View reviewed changes
Copy link
Member

@cpu cpu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing 👍

@ctz ctz added this pull request to the merge queue Mar 1, 2024
Merged via the queue into main with commit 69920b0 Mar 1, 2024
44 checks passed
@ctz ctz deleted the jbp-fips-docsrs branch March 1, 2024 14:31
@cpu cpu mentioned this pull request Apr 25, 2024
Closed
@tobz tobz mentioned this pull request Apr 26, 2024
Merged
@ctz ctz mentioned this pull request May 27, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

@cpu cpu cpu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

0.23 docs build is broken
3 participants
@ctz @djc @cpu