Avoid aws-lc-rs feature flag when building docs.
#273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djc
reviewed
Apr 26, 2024
|
Bypassed queue in order to squash during merge. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As stated in the title.
Mimics the fix in rustls/rustls#1827 by simply enabling all features manually, minus
aws-lc-rs. This avoids trying to build it at in during docs.rs generation, as docs.rs can't currently compile it, whether or not FIPS is enabled.There's nothing in the API, though, that depends on the feature flag so we didn't have to do anything in the code itself to cope with not passing the
aws-lc-rsfeature flag when building docs.Tested locally using the docs.rs build instructions and verified that the build was broken prior to this fix, and the build completed successfully with this fix.
Fixes #272.