Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve AcceptedAlert::write documentation, example usage #1868

Merged
merged 3 commits into from
Mar 22, 2024
Merged

Improve AcceptedAlert::write documentation, example usage #1868

merged 3 commits into from
Mar 22, 2024

Conversation

cpu
Copy link
Member

@cpu cpu commented Mar 21, 2024

Resolves #1867

@cpu cpu self-assigned this Mar 21, 2024
@cpu cpu mentioned this pull request Mar 21, 2024
Closed
djc
djc approved these changes Mar 21, 2024
View reviewed changes
rustls/src/server/server_conn.rs Outdated Show resolved Hide resolved
@cpu
server: improve AcceptedAlert::write documentation
58c1fbd 
The `wr: &mut dyn io::Write` provided to `AcceptedAlert::write` may
return from a short write without having written the entire alert
contents. To avoid dropping the remaining data in this circumstance
the caller should make sure to repeatedly call `AcceptedAlert::write`
until it returns `Ok(0)` or an error.
@cpu cpu force-pushed the cpu-1867-fixup-acceptor-alert branch from 576cc87 to fe308c1 Compare March 21, 2024 21:35
@codecov Codecov
Copy link

codecov bot commented Mar 21, 2024 •
edited

Codecov Report

Attention: Patch coverage is 0% with 4 lines in your changes are missing coverage. Please review.

Project coverage is 95.47%. Comparing base (667482a) to head (842dbf8).
Report is 3 commits behind head on main.

Files Patch % Lines
rustls/src/server/server_conn.rs 0.00% 4 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #1868      +/-   ##
==========================================
- Coverage   95.49%   95.47%   -0.03%     
==========================================
  Files          85       85              
  Lines       18585    18589       +4     
==========================================
  Hits        17747    17747              
- Misses        838      842       +4

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rustls-benchmarking Rustls Benchmarking
Copy link

rustls-benchmarking bot commented Mar 21, 2024 •
edited

Benchmark results

Instruction counts

Significant differences

There are no significant instruction count differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server 3908303 3948749 40446 (1.03%) 3.54%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server 4391918 4411526 19608 (0.45%) 2.85%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 8707669 8676287 -31382 (-0.36%) 0.76%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server 32346879 32277106 -69773 (-0.22%) 0.55%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server 12309648 12287265 -22383 (-0.18%) 0.62%
handshake_no_resume_ring_1.3_ecdsap256_aes_client 3920322 3914289 -6033 (-0.15%) 0.23%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server 32565185 32520342 -44843 (-0.14%) 0.43%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server 32589847 32552273 -37574 (-0.12%) 0.65%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client 30268929 30301182 32253 (0.11%) 0.35%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client 30314785 30284732 -30053 (-0.10%) 0.38%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 8673501 8681313 7812 (0.09%) 0.84%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server 46399784 46360762 -39022 (-0.08%) 0.42%
handshake_no_resume_ring_1.3_ecdsap256_aes_server 2135569 2133885 -1684 (-0.08%) 0.39%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 3362939 3365142 2203 (0.07%) 0.21%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client 3919762 3922308 2546 (0.06%) 0.23%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server 32276277 32295053 18776 (0.06%) 0.77%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server 46384773 46410809 26036 (0.06%) 0.31%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server 12705530 12712170 6640 (0.05%) 0.88%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server 12708779 12714747 5968 (0.05%) 0.86%
handshake_tickets_ring_1.2_rsa_aes_server 4665983 4663946 -2037 (-0.04%) 0.29%
handshake_session_id_ring_1.2_rsa_aes_server 4240726 4238916 -1810 (-0.04%) 0.33%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client 30068238 30078619 10381 (0.03%) 0.41%
handshake_no_resume_ring_1.3_ecdsap384_aes_server 13738914 13743586 4672 (0.03%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server 13741981 13746307 4326 (0.03%) 0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client 3173757 3174705 948 (0.03%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 1888563 1889091 528 (0.03%) 0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client 4289393 4288240 -1153 (-0.03%) 1.00%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client 92670344 92694438 24094 (0.03%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server 43625080 43615239 -9841 (-0.02%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_client 41970311 41961391 -8920 (-0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client 3971324 3970503 -821 (-0.02%) 0.67%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 3366069 3366690 621 (0.02%) 0.24%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client 58238418 58227971 -10447 (-0.02%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client 41965193 41957829 -7364 (-0.02%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client 3389304 3389847 543 (0.02%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client 30088121 30083442 -4679 (-0.02%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server 43319328 43313084 -6244 (-0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client 41771176 41765236 -5940 (-0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client 42031343 42037230 5887 (0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client 35470460 35475238 4778 (0.01%) 0.20%
handshake_tickets_ring_1.2_rsa_aes_client 4513094 4513680 586 (0.01%) 0.75%
transfer_no_resume_ring_1.3_ecdsap256_aes_client 58318566 58326117 7551 (0.01%) 0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client 35473043 35477608 4565 (0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server 80580516 80590462 9946 (0.01%) 0.29%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client 30100817 30097118 -3699 (-0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server 43416968 43411738 -5230 (-0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server 43696858 43691819 -5039 (-0.01%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client 4565926 4566451 525 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client 3378575 3378961 386 (0.01%) 0.20%
handshake_no_resume_ring_1.3_rsa_aes_client 4556823 4557308 485 (0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client 42039425 42035230 -4195 (-0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server 46462527 46458066 -4461 (-0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client 41850418 41846404 -4014 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client 30301924 30299060 -2864 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 1892564 1892741 177 (0.01%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server 43620605 43616854 -3751 (-0.01%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_server 43618532 43615384 -3148 (-0.01%) 0.23%
handshake_session_id_ring_1.3_ecdsap256_aes_client 41843217 41846208 2991 (0.01%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client 58222010 58217927 -4083 (-0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client 58320615 58316704 -3911 (-0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server 32304763 32302763 -2000 (-0.01%) 0.22%
handshake_session_id_ring_1.3_rsa_chacha_server 43311882 43309290 -2592 (-0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server 32333667 32331758 -1909 (-0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 4271419 4271167 -252 (-0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client 30334270 30332485 -1785 (-0.01%) 0.22%
handshake_no_resume_ring_1.3_rsa_aes_server 12242804 12243514 710 (0.01%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_server 12048927 12049623 696 (0.01%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server 43412411 43414917 2506 (0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client 92647418 92652631 5213 (0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server 32591324 32589513 -1811 (-0.01%) 0.20%
handshake_no_resume_ring_1.2_rsa_aes_client 4459194 4459439 245 (0.01%) 0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 4266524 4266744 220 (0.01%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server 46454533 46456908 2375 (0.01%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server 32590785 32589127 -1658 (-0.01%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server 32332958 32331323 -1635 (-0.01%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_server 43690731 43688561 -2170 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server 80515435 80511572 -3863 (-0.00%) 0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server 12252171 12252745 574 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server 32578449 32576973 -1476 (-0.00%) 0.29%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server 32304660 32303221 -1439 (-0.00%) 0.23%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client 92653097 92648994 -4103 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server 32578674 32577300 -1374 (-0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client 30288075 30286876 -1199 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server 80505005 80507665 2660 (0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_chacha_client 41814768 41813635 -1133 (-0.00%) 0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server 43693305 43694365 1060 (0.00%) 0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server 43314643 43313688 -955 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client 30124107 30123543 -564 (-0.00%) 0.42%
handshake_session_id_ring_1.3_ecdsap256_chacha_client 41762907 41762213 -694 (-0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_server 43408984 43408403 -581 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_client 58202197 58202910 713 (0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_client 58319703 58320280 577 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client 58222003 58222565 562 (0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client 30145553 30145827 274 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server 80609799 80610527 728 (0.00%) 0.20%
handshake_session_id_ring_1.2_rsa_aes_client 4246150 4246113 -37 (-0.00%) 0.52%
transfer_no_resume_ring_1.3_rsa_chacha_client 92652608 92653349 741 (0.00%) 0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client 30345907 30345668 -239 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server 46420051 46420391 340 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server 80608825 80608290 -535 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_aes_server 46457779 46457488 -291 (-0.00%) 0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server 80510983 80510481 -502 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client 68641892 68642187 295 (0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client 92690741 92690395 -346 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server 46418615 46418455 -160 (-0.00%) 0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client 30130946 30130853 -93 (-0.00%) 0.20%
handshake_session_id_ring_1.3_rsa_aes_client 41894450 41894331 -119 (-0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_aes_client 42088790 42088685 -105 (-0.00%) 0.20%
transfer_no_resume_ring_1.2_rsa_aes_server 46338504 46338413 -91 (-0.00%) 0.20%
handshake_tickets_ring_1.3_rsa_chacha_client 42020370 42020337 -33 (-0.00%) 0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client 92689530 92689595 65 (0.00%) 0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server 2137985 2137985 0 (0.00%) 0.38%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand
Scenario Baseline Candidate Diff Threshold
handshake_session_id_ring_1.2_rsa_aes 1.65 ms 1.65 ms 0.01 ms (0.53%) 2.00%
handshake_tickets_aws_lc_rs_1.2_rsa_aes 2.22 ms 2.21 ms -0.01 ms (-0.43%) 1.68%
handshake_tickets_ring_1.3_rsa_chacha 7.33 ms 7.31 ms -0.03 ms (-0.38%) 1.04%
handshake_session_id_ring_1.3_rsa_chacha 7.31 ms 7.28 ms -0.03 ms (-0.36%) 1.15%
handshake_session_id_aws_lc_rs_1.2_rsa_aes 2.06 ms 2.06 ms -0.01 ms (-0.36%) 1.70%
handshake_session_id_ring_1.3_ecdsap256_chacha 6.71 ms 6.69 ms -0.02 ms (-0.33%) 1.16%
handshake_session_id_ring_1.3_rsa_aes 7.35 ms 7.32 ms -0.02 ms (-0.32%) 1.00%
handshake_no_resume_ring_1.3_rsa_aes 1.09 ms 1.09 ms -0.00 ms (-0.32%) 1.00%
handshake_session_id_ring_1.3_ecdsap256_aes 6.74 ms 6.72 ms -0.02 ms (-0.30%) 1.15%
handshake_tickets_ring_1.3_rsa_aes 7.36 ms 7.34 ms -0.02 ms (-0.29%) 1.02%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha 6.18 ms 6.16 ms -0.02 ms (-0.29%) 1.51%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha 5.21 ms 5.20 ms -0.02 ms (-0.29%) 1.78%
handshake_tickets_ring_1.3_ecdsap256_chacha 6.73 ms 6.71 ms -0.02 ms (-0.29%) 1.24%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes 1.41 ms 1.41 ms 0.00 ms (0.27%) 1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha 5.90 ms 5.89 ms -0.01 ms (-0.22%) 1.48%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha 1.40 ms 1.40 ms 0.00 ms (0.22%) 1.00%
handshake_session_id_ring_1.3_ecdsap384_chacha 9.80 ms 9.78 ms -0.02 ms (-0.21%) 1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 1.18 ms 1.18 ms 0.00 ms (0.20%) 1.08%
handshake_tickets_ring_1.2_rsa_aes 1.73 ms 1.73 ms 0.00 ms (0.19%) 1.70%
transfer_no_resume_ring_1.3_ecdsap256_aes 6.29 ms 6.28 ms -0.01 ms (-0.19%) 3.27%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes 5.22 ms 5.21 ms -0.01 ms (-0.18%) 1.64%
transfer_no_resume_ring_1.3_rsa_aes 6.88 ms 6.87 ms -0.01 ms (-0.17%) 2.70%
handshake_tickets_ring_1.3_ecdsap384_chacha 9.82 ms 9.80 ms -0.02 ms (-0.16%) 1.00%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes 1.36 ms 1.36 ms 0.00 ms (0.14%) 1.01%
handshake_tickets_ring_1.3_ecdsap256_aes 6.76 ms 6.75 ms -0.01 ms (-0.13%) 1.10%
handshake_session_id_ring_1.3_ecdsap384_aes 9.83 ms 9.81 ms -0.01 ms (-0.13%) 1.00%
handshake_no_resume_ring_1.3_ecdsap256_aes 503.58 µs 504.19 µs 0.61 µs (0.12%) 1.90%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 471.15 µs 471.67 µs 0.51 µs (0.11%) 2.79%
handshake_session_id_aws_lc_rs_1.3_rsa_aes 6.18 ms 6.18 ms -0.01 ms (-0.11%) 1.51%
handshake_tickets_ring_1.3_ecdsap384_aes 9.85 ms 9.84 ms -0.01 ms (-0.09%) 1.00%
handshake_no_resume_ring_1.3_rsa_chacha 1.09 ms 1.09 ms -0.00 ms (-0.09%) 1.00%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha 6.19 ms 6.20 ms 0.01 ms (0.09%) 1.47%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes 5.39 ms 5.39 ms 0.00 ms (0.08%) 3.78%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes 471.71 µs 472.06 µs 0.35 µs (0.08%) 2.46%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes 1.18 ms 1.18 ms 0.00 ms (0.07%) 1.02%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes 5.93 ms 5.92 ms -0.00 ms (-0.06%) 1.44%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes 5.22 ms 5.23 ms 0.00 ms (0.06%) 1.60%
handshake_tickets_aws_lc_rs_1.3_rsa_aes 6.19 ms 6.19 ms 0.00 ms (0.05%) 1.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes 5.93 ms 5.94 ms 0.00 ms (0.05%) 1.26%
transfer_no_resume_ring_1.2_rsa_aes 6.78 ms 6.79 ms 0.00 ms (0.05%) 3.36%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes 5.38 ms 5.38 ms 0.00 ms (0.04%) 3.82%
transfer_no_resume_ring_1.3_ecdsap384_aes 9.40 ms 9.39 ms -0.00 ms (-0.04%) 2.23%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes 5.16 ms 5.16 ms 0.00 ms (0.04%) 3.94%
transfer_no_resume_ring_1.3_rsa_chacha 13.53 ms 13.52 ms -0.00 ms (-0.04%) 1.84%
handshake_no_resume_ring_1.3_ecdsap384_chacha 3.61 ms 3.61 ms -0.00 ms (-0.03%) 1.00%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes 4.44 ms 4.45 ms 0.00 ms (0.03%) 4.68%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha 13.87 ms 13.87 ms -0.00 ms (-0.02%) 1.51%
handshake_no_resume_ring_1.3_ecdsap256_chacha 501.93 µs 502.01 µs 0.08 µs (0.02%) 2.00%
handshake_no_resume_ring_1.2_rsa_aes 1.07 ms 1.07 ms 0.00 ms (0.02%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha 5.93 ms 5.93 ms 0.00 ms (0.01%) 1.61%
transfer_no_resume_ring_1.3_ecdsap384_chacha 16.04 ms 16.04 ms -0.00 ms (-0.01%) 1.35%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha 12.92 ms 12.92 ms -0.00 ms (-0.01%) 1.53%
transfer_no_resume_ring_1.3_ecdsap256_chacha 12.94 ms 12.94 ms -0.00 ms (-0.01%) 1.81%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha 13.63 ms 13.63 ms -0.00 ms (-0.01%) 1.55%
handshake_no_resume_ring_1.3_ecdsap384_aes 3.61 ms 3.61 ms 0.00 ms (0.01%) 1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha 5.23 ms 5.23 ms 0.00 ms (0.00%) 1.51%

Additional information

Historical results

Checkout details:

cpu added 2 commits March 22, 2024 09:33
@cpu
server: add AcceptedAlert::write_all
e8591b1 
This is a convenient helper for blocking contexts where the caller
simply wants to ensure all bytes are written in a single call.
@cpu
examples: fix server acceptor alert write behaviour
842dbf8 
The `AcceptedAlert::write` fn may return having only written some of the
alert buffer. We could either repeatedly call `write` until it
returns `Ok(0)` or an error, or use the new `write_all` fn. This commit
does updates the acceptor example to do the latter.
@cpu cpu force-pushed the cpu-1867-fixup-acceptor-alert branch from fe308c1 to 842dbf8 Compare March 22, 2024 13:33
@cpu cpu requested a review from ctz March 22, 2024 14:52
@cpu cpu added this pull request to the merge queue Mar 22, 2024
Merged via the queue into rustls:main with commit 3185d7f Mar 22, 2024
24 of 25 checks passed
@cpu cpu deleted the cpu-1867-fixup-acceptor-alert branch March 22, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@djc djc djc approved these changes

@jsha jsha jsha approved these changes

@ctz ctz ctz approved these changes

Assignees

@cpu cpu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

doc: AcceptedAlert::write doesn't necessarily write all bytes
4 participants
@cpu @djc @jsha @ctz