Small correction to the quic::PacketKey::integrity_limit doc

[MOZGIII]

Follow up after #1798 (comment)

[cpu]

Thanks!

[rustls-benchmarking]

Benchmark results

Instruction counts

Significant differences

There are no significant instruction count differences

Other differences

Click to expand

Scenario	Baseline	Candidate	Diff	Threshold
handshake_session_id_aws_lc_rs_1.2_rsa_aes_server	3872776	3979738	106962 (2.76%)	7.31%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_server	4350043	4419630	69587 (1.60%)	1.65%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_server	13405017	13344377	-60640 (-0.45%)	0.72%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_server	32354255	32424816	70561 (0.22%)	0.62%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client	8737079	8718085	-18994 (-0.22%)	1.12%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client	8712849	8730024	17175 (0.20%)	0.65%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_client	30093653	30149874	56221 (0.19%)	0.28%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_server	13748136	13723485	-24651 (-0.18%)	2.11%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_server	32643896	32689800	45904 (0.14%)	0.71%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_client	30378692	30344862	-33830 (-0.11%)	0.46%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_client	30302100	30334543	32443 (0.11%)	0.35%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_server	46378722	46427187	48465 (0.10%)	0.37%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_server	32659517	32628624	-30893 (-0.09%)	0.75%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_client	30160960	30136504	-24456 (-0.08%)	0.29%
handshake_no_resume_ring_1.3_ecdsap256_chacha_client	3913815	3916379	2564 (0.07%)	0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_server	80608901	80656976	48075 (0.06%)	0.31%
handshake_no_resume_ring_1.3_ecdsap256_aes_client	3914649	3912588	-2061 (-0.05%)	0.23%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_client	58256372	58233684	-22688 (-0.04%)	0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_server	46493853	46477309	-16544 (-0.04%)	0.31%
handshake_tickets_ring_1.2_rsa_aes_client	4506750	4507874	1124 (0.02%)	0.20%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha_client	2222480	2222980	500 (0.02%)	0.20%
handshake_no_resume_ring_1.3_ecdsap256_chacha_server	2131364	2131796	432 (0.02%)	0.35%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_server	13728348	13725673	-2675 (-0.02%)	1.64%
handshake_no_resume_ring_1.2_rsa_aes_client	2856691	2856194	-497 (-0.02%)	0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server	4273672	4273055	-617 (-0.01%)	0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_server	32427183	32431384	4201 (0.01%)	0.74%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client	3366628	3366199	-429 (-0.01%)	0.27%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes_client	2215752	2215476	-276 (-0.01%)	0.20%
handshake_tickets_ring_1.2_rsa_aes_server	4663914	4663344	-570 (-0.01%)	0.20%
handshake_tickets_aws_lc_rs_1.2_rsa_aes_client	4300301	4299782	-519 (-0.01%)	0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server	1895216	1894995	-221 (-0.01%)	0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_client	92681935	92691556	9621 (0.01%)	0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server	1891813	1891969	156 (0.01%)	0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_client	41970743	41967424	-3319 (-0.01%)	0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_client	41848221	41851006	2785 (0.01%)	0.20%
handshake_session_id_aws_lc_rs_1.2_rsa_aes_client	3973043	3973299	256 (0.01%)	0.20%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes_client	2014916	2014787	-129 (-0.01%)	0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_client	42036753	42039222	2469 (0.01%)	0.20%
handshake_session_id_ring_1.2_rsa_aes_client	4233304	4233060	-244 (-0.01%)	0.20%
handshake_no_resume_ring_1.3_rsa_chacha_client	2954822	2954987	165 (0.01%)	0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_client	41770204	41768078	-2126 (-0.01%)	0.20%
handshake_no_resume_ring_1.3_ecdsap256_aes_server	2129434	2129538	104 (0.00%)	0.22%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_client	30156016	30157393	1377 (0.00%)	0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_aes_client	30170633	30171965	1332 (0.00%)	0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_client	30331955	30333125	1170 (0.00%)	0.20%
handshake_session_id_ring_1.2_rsa_aes_server	4231923	4231764	-159 (-0.00%)	0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server	4276427	4276576	149 (0.00%)	0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_client	58318282	58320253	1971 (0.00%)	0.20%
handshake_session_id_ring_1.3_rsa_aes_client	41862436	41861052	-1384 (-0.00%)	0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_client	92653756	92650853	-2903 (-0.00%)	0.20%
handshake_session_id_ring_1.3_rsa_chacha_client	41781937	41780700	-1237 (-0.00%)	0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_client	58232684	58231328	-1356 (-0.00%)	0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes_server	32410826	32411574	748 (0.00%)	0.20%
handshake_no_resume_ring_1.3_rsa_aes_server	12168059	12168327	268 (0.00%)	0.20%
handshake_no_resume_ring_1.3_rsa_aes_client	2949204	2949144	-60 (-0.00%)	0.20%
handshake_tickets_ring_1.3_rsa_aes_client	42049825	42050671	846 (0.00%)	0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha_server	32649201	32649829	628 (0.00%)	0.20%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha_client	30145459	30145979	520 (0.00%)	0.20%
handshake_tickets_ring_1.3_rsa_aes_server	43690649	43689911	-738 (-0.00%)	0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_client	42032733	42032036	-697 (-0.00%)	0.20%
handshake_no_resume_ring_1.2_rsa_aes_server	11985232	11985419	187 (0.00%)	0.20%
handshake_tickets_ring_1.3_ecdsap384_aes_server	43693173	43692492	-681 (-0.00%)	0.20%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client	3368517	3368568	51 (0.00%)	0.22%
handshake_tickets_ring_1.3_ecdsap384_chacha_client	41963369	41962749	-620 (-0.00%)	0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_client	41845286	41844718	-568 (-0.00%)	0.20%
handshake_tickets_ring_1.3_ecdsap384_chacha_server	43618133	43617543	-590 (-0.00%)	0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_server	13737686	13737503	-183 (-0.00%)	0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes_server	4642997	46430567	590 (0.00%)	0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes_server	32672721	32673131	410 (0.00%)	0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_server	32673601	32674008	407 (0.00%)	0.20%
handshake_session_id_ring_1.3_ecdsap384_aes_server	43411429	43411969	540 (0.00%)	0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes_server	46430357	46429911	-446 (-0.00%)	0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes_client	58234082	58234635	553 (0.00%)	0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_server	32370848	32371145	297 (0.00%)	0.20%
handshake_no_resume_ring_1.3_rsa_chacha_server	12174254	12174148	-106 (-0.00%)	0.20%
transfer_no_resume_ring_1.3_ecdsap256_chacha_server	80507186	80506562	-624 (-0.00%)	0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha_client	30347936	30347705	-231 (-0.00%)	0.20%
handshake_session_id_ring_1.3_ecdsap256_chacha_server	43310777	43310478	-299 (-0.00%)	0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_client	92690623	92690001	-622 (-0.00%)	0.20%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha_client	92692218	92691654	-564 (-0.00%)	0.20%
transfer_no_resume_ring_1.3_rsa_aes_server	46461703	46461434	-269 (-0.00%)	0.20%
handshake_tickets_aws_lc_rs_1.3_rsa_aes_client	30370321	30370170	-151 (-0.00%)	0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_server	46457424	46457650	226 (0.00%)	0.20%
handshake_tickets_ring_1.3_ecdsap256_aes_server	43692764	43692563	-201 (-0.00%)	0.20%
handshake_session_id_ring_1.3_rsa_chacha_server	43308059	43307873	-186 (-0.00%)	0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha_server	32372002	32372138	136 (0.00%)	0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_server	43310601	43310422	-179 (-0.00%)	0.20%
handshake_tickets_ring_1.3_rsa_chacha_client	41981358	41981528	170 (0.00%)	0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha_client	30132987	30132867	-120 (-0.00%)	0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha_server	80608882	80609184	302 (0.00%)	0.20%
transfer_no_resume_ring_1.3_rsa_chacha_server	80514728	80515024	296 (0.00%)	0.20%
transfer_no_resume_ring_1.2_rsa_aes_server	46361839	46361675	-164 (-0.00%)	0.20%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes_server	32411476	32411585	109 (0.00%)	0.20%
handshake_session_id_ring_1.3_ecdsap384_chacha_client	41762874	41762999	125 (0.00%)	0.20%
handshake_tickets_ring_1.3_rsa_chacha_server	43615140	43615013	-127 (-0.00%)	0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes_client	30356663	30356582	-81 (-0.00%)	0.20%
transfer_no_resume_ring_1.3_ecdsap256_aes_server	46453870	46453950	80 (0.00%)	0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_client	92647694	92647558	-136 (-0.00%)	0.20%
transfer_no_resume_ring_1.3_rsa_chacha_client	92652335	92652203	-132 (-0.00%)	0.20%
handshake_tickets_ring_1.3_ecdsap256_chacha_server	43617654	43617715	61 (0.00%)	0.20%
handshake_no_resume_ring_1.3_ecdsap384_aes_client	35471576	35471625	49 (0.00%)	0.20%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha_server	32649318	32649363	45 (0.00%)	0.20%
handshake_session_id_ring_1.3_rsa_aes_server	43408563	43408618	55 (0.00%)	0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_client	35473650	35473694	44 (0.00%)	0.20%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes_client	68655992	68656056	64 (0.00%)	0.20%
transfer_no_resume_ring_1.3_ecdsap384_aes_client	58315317	58315367	50 (0.00%)	0.20%
handshake_no_resume_ring_1.3_ecdsap384_chacha_server	13739932	13739939	7 (0.00%)	0.20%
transfer_no_resume_ring_1.3_ecdsap384_chacha_server	80510252	80510284	32 (0.00%)	0.20%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha_server	80609522	80609549	27 (0.00%)	0.20%
transfer_no_resume_ring_1.3_rsa_aes_client	58319401	58319420	19 (0.00%)	0.20%
transfer_no_resume_ring_1.2_rsa_aes_client	58202664	58202652	-12 (-0.00%)	0.20%
handshake_session_id_ring_1.3_ecdsap256_aes_server	43410579	43410581	2 (0.00%)	0.20%

Wall-time

Significant differences

There are no significant wall-time differences

Other differences

Click to expand

Scenario	Baseline	Candidate	Diff	Threshold
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_aes	4.50 ms	4.56 ms	0.06 ms (1.34%)	3.19%
transfer_no_resume_aws_lc_rs_1.3_rsa_aes	5.43 ms	5.49 ms	0.06 ms (1.09%)	3.54%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_aes	5.21 ms	5.27 ms	0.05 ms (1.04%)	3.21%
transfer_no_resume_ring_1.3_ecdsap256_aes	6.32 ms	6.38 ms	0.06 ms (0.94%)	2.33%
transfer_no_resume_aws_lc_rs_1.2_rsa_aes	5.43 ms	5.48 ms	0.05 ms (0.91%)	3.70%
transfer_no_resume_ring_1.3_rsa_aes	6.81 ms	6.87 ms	0.06 ms (0.86%)	2.56%
transfer_no_resume_ring_1.2_rsa_aes	6.72 ms	6.77 ms	0.05 ms (0.78%)	2.58%
handshake_no_resume_ring_1.3_ecdsap256_aes	504.39 µs	508.00 µs	3.61 µs (0.72%)	2.36%
handshake_no_resume_ring_1.3_ecdsap256_chacha	502.27 µs	505.11 µs	2.85 µs (0.57%)	1.85%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_aes	477.00 µs	479.48 µs	2.48 µs (0.52%)	3.99%
handshake_no_resume_aws_lc_rs_1.3_ecdsap256_chacha	476.19 µs	478.60 µs	2.40 µs (0.50%)	3.20%
transfer_no_resume_ring_1.3_ecdsap384_aes	9.43 ms	9.48 ms	0.05 ms (0.50%)	1.45%
transfer_no_resume_ring_1.3_ecdsap256_chacha	12.96 ms	13.02 ms	0.06 ms (0.46%)	1.14%
handshake_session_id_ring_1.2_rsa_aes	1.54 ms	1.55 ms	0.01 ms (0.46%)	1.35%
transfer_no_resume_aws_lc_rs_1.3_ecdsap256_chacha	12.96 ms	13.02 ms	0.06 ms (0.44%)	1.46%
transfer_no_resume_aws_lc_rs_1.3_rsa_chacha	13.90 ms	13.96 ms	0.06 ms (0.42%)	1.22%
handshake_tickets_ring_1.2_rsa_aes	1.62 ms	1.63 ms	0.01 ms (0.41%)	2.03%
transfer_no_resume_aws_lc_rs_1.3_ecdsap384_chacha	13.67 ms	13.73 ms	0.06 ms (0.40%)	1.40%
transfer_no_resume_ring_1.3_rsa_chacha	13.46 ms	13.52 ms	0.05 ms (0.39%)	1.07%
handshake_session_id_ring_1.3_ecdsap256_aes	6.69 ms	6.72 ms	0.02 ms (0.35%)	1.00%
transfer_no_resume_ring_1.3_ecdsap384_chacha	16.07 ms	16.12 ms	0.05 ms (0.33%)	1.00%
handshake_no_resume_aws_lc_rs_1.3_rsa_chacha	1.39 ms	1.40 ms	0.00 ms (0.32%)	1.00%
handshake_tickets_ring_1.3_rsa_aes	7.21 ms	7.24 ms	0.02 ms (0.31%)	1.00%
handshake_no_resume_ring_1.2_rsa_aes	975.45 µs	978.23 µs	2.78 µs (0.29%)	1.00%
handshake_no_resume_ring_1.3_rsa_aes	996.04 µs	998.85 µs	2.80 µs (0.28%)	1.00%
handshake_no_resume_aws_lc_rs_1.3_rsa_aes	1.41 ms	1.41 ms	0.00 ms (0.28%)	1.49%
handshake_tickets_ring_1.3_ecdsap256_chacha	6.67 ms	6.69 ms	0.02 ms (0.28%)	1.01%
handshake_session_id_ring_1.3_rsa_aes	7.19 ms	7.21 ms	0.02 ms (0.27%)	1.00%
handshake_tickets_ring_1.3_ecdsap256_aes	6.73 ms	6.74 ms	0.02 ms (0.26%)	1.06%
handshake_tickets_ring_1.3_ecdsap384_aes	9.81 ms	9.83 ms	0.02 ms (0.24%)	1.00%
handshake_no_resume_ring_1.3_rsa_chacha	1.00 ms	1.00 ms	0.00 ms (0.24%)	1.00%
handshake_session_id_ring_1.3_ecdsap256_chacha	6.65 ms	6.67 ms	0.02 ms (0.24%)	1.00%
handshake_session_id_ring_1.3_rsa_chacha	7.14 ms	7.16 ms	0.02 ms (0.24%)	1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_chacha	1.18 ms	1.18 ms	0.00 ms (0.23%)	1.05%
handshake_session_id_aws_lc_rs_1.3_rsa_chacha	6.15 ms	6.17 ms	0.01 ms (0.23%)	1.03%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_chacha	5.22 ms	5.23 ms	0.01 ms (0.23%)	1.00%
handshake_tickets_ring_1.3_rsa_chacha	7.16 ms	7.18 ms	0.02 ms (0.23%)	1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_chacha	5.91 ms	5.93 ms	0.01 ms (0.22%)	1.00%
handshake_no_resume_aws_lc_rs_1.2_rsa_aes	1.35 ms	1.36 ms	0.00 ms (0.22%)	1.46%
handshake_tickets_ring_1.3_ecdsap384_chacha	9.75 ms	9.78 ms	0.02 ms (0.22%)	1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_chacha	5.95 ms	5.96 ms	0.01 ms (0.20%)	1.00%
handshake_session_id_ring_1.3_ecdsap384_aes	9.78 ms	9.80 ms	0.02 ms (0.18%)	1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_aes	5.24 ms	5.25 ms	0.01 ms (0.17%)	1.06%
handshake_session_id_aws_lc_rs_1.2_rsa_aes	2.04 ms	2.04 ms	0.00 ms (0.16%)	2.52%
handshake_tickets_aws_lc_rs_1.3_ecdsap384_aes	5.96 ms	5.97 ms	0.01 ms (0.14%)	1.00%
handshake_tickets_aws_lc_rs_1.3_rsa_aes	6.18 ms	6.19 ms	0.01 ms (0.14%)	1.29%
handshake_session_id_aws_lc_rs_1.3_rsa_aes	6.17 ms	6.18 ms	0.01 ms (0.13%)	1.02%
handshake_session_id_aws_lc_rs_1.3_ecdsap384_aes	5.94 ms	5.94 ms	0.01 ms (0.13%)	1.00%
handshake_session_id_ring_1.3_ecdsap384_chacha	9.74 ms	9.75 ms	0.01 ms (0.13%)	1.00%
handshake_session_id_aws_lc_rs_1.3_ecdsap256_aes	5.22 ms	5.23 ms	0.01 ms (0.12%)	1.00%
handshake_tickets_aws_lc_rs_1.3_ecdsap256_chacha	5.24 ms	5.25 ms	0.01 ms (0.12%)	1.01%
handshake_no_resume_ring_1.3_ecdsap384_aes	3.60 ms	3.60 ms	0.00 ms (0.12%)	1.00%
handshake_tickets_aws_lc_rs_1.3_rsa_chacha	6.19 ms	6.19 ms	0.01 ms (0.12%)	1.06%
handshake_no_resume_ring_1.3_ecdsap384_chacha	3.60 ms	3.60 ms	0.00 ms (0.11%)	1.00%
handshake_no_resume_aws_lc_rs_1.3_ecdsap384_aes	1.19 ms	1.19 ms	0.00 ms (0.07%)	1.06%
handshake_tickets_aws_lc_rs_1.2_rsa_aes	2.20 ms	2.20 ms	-0.00 ms (-0.06%)	1.99%

Additional information

Historical results

Checkout details:

• Base repo: https://github.com/rustls/rustls.git
• Base branch: main (59c33df)
• Candidate repo: https://github.com/MOZGIII/rustls.git
• Candidate branch: quic-fixes-2 (cbf1dc5)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.49%. Comparing base (59c33df) to head (cbf1dc5).

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #1930   +/-   ##
=======================================
  Coverage   95.49%   95.49%           
=======================================
  Files          86       86           
  Lines       18650    18650           
=======================================
  Hits        17810    17810           
  Misses        840      840           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.