-
Notifications
You must be signed in to change notification settings - Fork 621
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bogo: fix config rewriting when cpp is clang #1948
Conversation
Benchmark resultsInstruction countsSignificant differencesThere are no significant instruction count differences Other differencesClick to expand
Wall-timeSignificant differencesThere are no significant wall-time differences Other differencesClick to expand
Additional informationCheckout details:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1948 +/- ##
=======================================
Coverage 95.48% 95.48%
=======================================
Files 86 86
Lines 18654 18654
=======================================
Hits 17811 17811
Misses 843 843 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fwiw clang-cpp-15
worked in both ways for me
Weird. On my Mac the command writes to a file called |
The previous setup failed for me on macOS, where
cpp
is "Apple clang version 15.0.0 (clang-1500.3.9.4)". I think this approach works with both gcc ("cpp (Gentoo 13.2.1_p20240210 p14) 13.2.1 20240210") and clang.