-
Notifications
You must be signed in to change notification settings - Fork 208
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Name doesn't appear in the alert from hello world exercise #163
Comments
Hi Friend, |
I wonder if it would make sense to add some regression testing to the book's examples. Having a hello world example at the very beginning of a tutorial fail is not a good first impression for users. I realize this whole thing is super new so we shouldn't expect things to be nice and polished at this point, though. Just thinking out loud. |
I suspect that this is rustwasm/wasm-bindgen#1436 if 0.2.40 works and 0.2.41 doesn't. That just means it's basically a 17-hour-old regression (and this issue is 13 hours old!) so we should have this fixed soon :) |
Closing now that the fix had landed and I'll publish a new version soon. |
Describe the bug
I'm going through the tutorial and just came to the end of the "hello world" page. At the bottom there is an "exercises" section that asks you to modify the
greet
function to take a name. When running the code exactly as shown, the browser alert does not include the name passed to the function. It simply displaysHello, !
. I made sure that my code is identical to what is shown in the answer section, re-ranwasm-pack build
from the root of the project, and even restarted the webpack development server just to be sure. Same result.To Reproduce
Steps to reproduce the behavior:
Expected behavior
The alert should say
Hello, Your Name!
.Additional context
Software used:
rustc 1.35.0-nightly (3750348da 2019-04-08)
wasm-bindgen 0.2.41
npm 6.9.0
Firefox 66.0.2
The text was updated successfully, but these errors were encountered: