Fix a bug using encodeInto truncating strings
#1442
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The last write accidentally wasn't accounted for in the returned length of the string and we unfortunately don't have any test coverage of `encodeInto` since it requires Firefox nightly right now (and doesn't work in Node yet). Closes rustwasm#1436
|
(facepalm) sorry! I thought it was covered... |
RReverser
approved these changes
Apr 11, 2019
|
I'm realizing now we do actually have coverage of this nowadays, I think we just historically didn't! Yesterday I was confused that tests failed on the release PR and was going to investigate more today, but I realized today that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last write accidentally wasn't accounted for in the returned length
of the string and we unfortunately don't have any test coverage of
encodeIntosince it requires Firefox nightly right now (and doesn'twork in Node yet).
Closes #1436