Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to strip the custom name section #1021

Closed
fitzgen opened this issue Nov 8, 2018 · 0 comments
Closed

Add option to strip the custom name section #1021

fitzgen opened this issue Nov 8, 2018 · 0 comments

Comments

@fitzgen
Copy link
Member

fitzgen commented Nov 8, 2018

When we are making builds for production, we want them stripped and don't want to have the names section. We should have a CLI flag that wasm-pack can pass to strip the name section.
alexcrichton added a commit to alexcrichton/wasm-bindgen that referenced this issue Nov 9, 2018
@alexcrichton
Add a flag to remove the wasm name section
12fc09a 
This commit adds a `--remove-name-section` flag to the `wasm-bindgen`
command which will remove the `name` section of the wasm file, used to
indicate the names of functions typically used in debugging. This flag
is off-by-default and will primarily be controlled by wasm-pack,
typically being passed by default with `wasm-pack build --release`.

Closes rustwasm#1021
@alexcrichton alexcrichton mentioned this issue Nov 9, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@fitzgen