Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Regression: can't instantiate wasm-bindgen with instance of WebAssembly.Module #2010

Closed
RReverser opened this issue Feb 20, 2020 · 0 comments · Fixed by #2011
Closed

Regression: can't instantiate wasm-bindgen with instance of WebAssembly.Module #2010

RReverser opened this issue Feb 20, 2020 · 0 comments · Fixed by #2011
Labels
bug

Comments

@RReverser
Copy link
Member

Describe the Bug

On master wasm-bindgen trying to instantiate wasm-bindgen with a custom instance of WebAssembly.Module (e.g. in a Cloudflare Worker) results in an error due to maybe_memory being undefined:

image

If you check the generated code with ESLint, it also warns that variable is not defined anywhere:

image

This appears to be a regression, perhaps caused by a refactor in #1996? (cc @Pauan)
@RReverser RReverser added the bug label Feb 20, 2020
RReverser added a commit to RReverser/wasm-bindgen that referenced this issue Feb 20, 2020
@RReverser
Propagate missing memory argument
23f469f 
Fixes rustwasm#2010.
@RReverser RReverser mentioned this issue Feb 20, 2020
Merged
alexcrichton pushed a commit that referenced this issue Feb 20, 2020
@RReverser
Propagate missing memory argument (#2011)
d26068d 
Fixes #2010.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Propagate missing memory argument RReverser/wasm-bindgen
1 participant
@RReverser