Format web-sys bindings by default #1461
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit switches to executing `rustfmt` by default on `web-sys`-generated bindings. This improves situations like "view source" in Rustdoc as well as the IDE interactive debugging experience. This was initially disabled by default because `rustfmt` took so long to execute, but nowadays `web-sys` is by default much smaller so there's much less need to avoid running `rustfmt` in fear of it taking too long. Closes rustwasm#1457
fitzgen
approved these changes
Apr 15, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit switches to executing
rustfmtby default onweb-sys-generated bindings. This improves situations like "viewsource" in Rustdoc as well as the IDE interactive debugging experience.
This was initially disabled by default because
rustfmttook so long toexecute, but nowadays
web-sysis by default much smaller so there'smuch less need to avoid running
rustfmtin fear of it taking toolong.
Closes #1457