Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix small issues around web-sys dictionaries #1572

Merged
merged 2 commits into from
Jun 3, 2019
Merged

Fix small issues around web-sys dictionaries #1572

merged 2 commits into from
Jun 3, 2019

Commits on Jun 3, 2019

  1. web-sys: Don't remove dictionaries if required fields are removed 

    This commit updates the conditional binding generation for dictionaries
to ensure that a dictionary is not entirely removed if any of its
required fields are removed. If a required field is removed, however, it
cannot be constructed, so the constructor is removed.
    @alexcrichton
    alexcrichton committed Jun 3, 2019
    Configuration menu
    Copy the full SHA
    877c31c View commit details
    Browse the repository at this point in the history

  2. Add doc comments to web-sys dictionaries/fields 

    This commit ensures that web-sys generated dictionaries and fields all
have comments like interfaces do, indicating a bare minimum of what's
happening as well as the required features to enable the API.
    @alexcrichton
    alexcrichton committed Jun 3, 2019
    Configuration menu
    Copy the full SHA
    117928f View commit details
    Browse the repository at this point in the history