Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(test): test CLI on windows #1978

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

ashleygwilliams
Copy link
Member

we're running into a geckodriver issue on windows (appears to be just a CI issue, but hard to say)- but i had the occasion to take a look at the azure-pipelines config here. it looks like the library portion of this project is tested on all 3 platforms, but the cli tool is not.

i know it's a non-zero addition to ask ya'll to add tests, but it would be very help to have the cli tests run on windows so we can catch issues that might begin here first. my concern is mostly wasm-bindgen-test, since it's significantly more tenuous x-platform.

would love to hear your thoughts!

@alexcrichton
Copy link
Contributor

In general I've been wary to add extra tests here since the likelihood of regressions on just one platform are pretty rare and it's otherwise a pain to keep it up and running (not to mention expensive on resources). I think though it's best to evaluate the costs after seeing what it would look like to see things working, so I wouldn't mind taking another look once CI is green.

@vojta7 vojta7 mentioned this pull request Apr 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants