Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clipboard API #2100

Merged
merged 4 commits into from
Apr 23, 2020
Merged

Clipboard API #2100

merged 4 commits into from
Apr 23, 2020

Conversation

vojta7
Copy link
Contributor

@vojta7 vojta7 commented Apr 22, 2020

@vojta7
Copy link
Contributor Author

vojta7 commented Apr 22, 2020

Some tests are failing because there is already a specified subset of Clipboard API in ClipboardEvent.webidl. To my understanding, it is part of the same working draft, so it should be unstable.

How should I resolve this conflict? Remove old specification and keep only content of my pull request (if so in unstable or enabled?), or just ignore it?

@alexcrichton
Copy link
Contributor

If it was an already-unstable API I think it's fine to delete the original WebIDL in favor of the new unstable WebIDL

@vojta7
Copy link
Contributor Author

vojta7 commented Apr 22, 2020

I don't understand why is the remaining test failing. It seems just like the wrong order of declarations, can I fix it somehow?

@alexcrichton
Copy link
Contributor

This could perhaps be instability in the bindings generator (maybe a hash map somewhere?) or perhaps a merge that needs to happen before regenerating?

@Pauan
Copy link
Contributor

Pauan commented Apr 22, 2020

@vojta7 You probably just have a different version of Rust, make sure your Rust is up to date (rustup update) and that you're on the Stable channel. You should also try running cargo update in the wasm-bindgen repository.

@vojta7
Copy link
Contributor Author

vojta7 commented Apr 22, 2020

@Pauan I tried your suggestions, but the generated code is still the same.

@vojta7
Copy link
Contributor Author

vojta7 commented Apr 22, 2020

I did also try to rebase onto the current master (last force push), but the tests are still failing.

@Pauan
Copy link
Contributor

Pauan commented Apr 22, 2020

@vojta7 Okay, then it's probably caused by non-determinism in the bindings generator, let me take a look.

@Pauan
Copy link
Contributor

Pauan commented Apr 23, 2020

@vojta7 Since #2101 was merged, could you rebase and try again?

@vojta7
Copy link
Contributor Author

vojta7 commented Apr 23, 2020

Thank you for your time :), it did help.

I also think that #1978 may have failed due to the same nondeterminism.

@Pauan Pauan merged commit a479241 into rustwasm:master Apr 23, 2020
@Pauan
Copy link
Contributor

Pauan commented Apr 23, 2020

Thanks!

@vojta7 vojta7 deleted the clipboard branch April 24, 2020 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants