Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Adds support to enums with values #2631

Closed

Conversation

celsobonutti
Copy link

No description provided.

@alexcrichton
Copy link
Contributor

Thanks for the PR! Sorry I don't have a ton of time to help you design this feature. I can try to help review it and see if it's something that makes sense to add, but I can't offer much assistance in the intermediate stages.

@celsobonutti
Copy link
Author

No problems! I'm afraid I won't have much time to work on this in the near future as I had last week, so this might take a while to progress, but I'll keep working on it. I think I'm slowly understanding everything I need to work on it. :)

@samvv
Copy link

samvv commented Aug 23, 2021

I'm currently hacking on this feature. I've managed to make the examples compile, but the code generator still needs to be tweaked. Will keep you posted how it goes.

@samvv
Copy link

samvv commented Aug 25, 2021

Ok so I did a bit more work. I'm looking how to best tackle the modifications in src/js/mod.rs of the cli-support crate. The current implementation uses a mixture of some temporary data structures and string concatenation, which feels a bit fragile. Maybe we could (ab)use a JavaScript AST such as the one used by swc? Or some kind of simple template language? Just thinking out loud here.

@trevyn
Copy link
Contributor

trevyn commented Aug 26, 2021

@samvv and @celsobonutti I don't have any comments on your approaches, but I wanted to throw in a hearty appreciation for your working on this! A very important feature, in my opinion.

@toksdotdev
Copy link

@celsobonutti Any possibility I could give this a shot?

@celsobonutti
Copy link
Author

Hey @tnkemdilim! Sure. Haven't touch this code in a while, so I guess it can be a bit outated, though.

@ZhaoXiangXML
Copy link

I'm working on complete this PR. I've some progress at ZhaoXiangXML#1 however there's still a long way to go.

@celsobonutti
Copy link
Author

Hey y'all. Unfortunately, I won't be able to keep working on this, as I've changed jobs and no longer have allocated time to do WASM OSS work.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants