New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Weather report example improvement #3134

Merged

alexcrichton merged 3 commits into rustwasm:main from eli-front:weather-report-example-improvement

Nov 6, 2022

Contributor

eli-front commented Nov 6, 2022

set_attribute can throw an error, which was not being handled
this PR adds basic error handling to all uses of set_attribute in weather report example

eli-front added 3 commits

November 6, 2022 00:59


          remove unused ShortHash


          Revert "remove unused ShortHash"

3451f9c

This reverts commit 9138890.


          fix set attr error handling

998b805

alexcrichton merged commit 6139212 into rustwasm:main

eli-front deleted the weather-report-example-improvement branch

November 6, 2022 21:09

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet