-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement coverage output #3782
Closed
Closed
Changes from all commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
b2d43e9
Add console_warn and console_error macros
aDogCalledSpot c850010
Implement coverage output
aDogCalledSpot 76c48f1
Address requested changes
aDogCalledSpot 85c93f0
Ensure interoperability with normal cargo test
aDogCalledSpot 88d5b68
add profraw prefix
aDogCalledSpot e8f74a2
cargo fmt
aDogCalledSpot b7f8bfc
Document coverage in the guide
aDogCalledSpot File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,29 @@ | ||
use wasm_bindgen::prelude::wasm_bindgen; | ||
|
||
#[cfg(feature = "unstable-coverage")] | ||
#[wasm_bindgen] | ||
pub fn __wbgtest_cov_dump() -> Vec<u8> { | ||
let mut coverage = Vec::new(); | ||
unsafe { | ||
minicov::capture_coverage(&mut coverage).unwrap(); | ||
} | ||
if coverage.is_empty() { | ||
console_error!( | ||
"Empty coverage data received. Make sure you compile the tests with | ||
RUSTFLAGS=\"-Cinstrument-coverage -Zno-profile-runtime --emit=llvm-ir\"", | ||
); | ||
} | ||
coverage | ||
} | ||
|
||
/// Called when setting WASM_BINDGEN_UNSTABLE_TEST_COVERAGE but coverage feature is disabled. | ||
/// Currently not being used because of issues in the interpreter regarding profiling | ||
/// information which cause an error before we get here. | ||
#[cfg(not(feature = "unstable-coverage"))] | ||
#[wasm_bindgen] | ||
pub fn __wbgtest_cov_dump() -> Vec<u8> { | ||
console_error!( | ||
"Coverage was supposed to be dumped, but the \"coverage\" feature is disabled in wasm-bindgen-test", | ||
); | ||
Vec::new() | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can't really review Node or Deno stuff, so I will be pulling in another maintainer when we get there.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is the only thing missing.