feat(webdriver): support geckodriver for linux-aarch64
#1371
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Interesting, I changed geckodriver's code but chromedriver is failing here 🤔 https://github.com/rustwasm/wasm-pack/actions/runs/8069923360/job/22046060320?pr=1371#step:7:472 |
|
The version fetched from https://googlechromelabs.github.io/chrome-for-testing/last-known-good-versions.json seems to be cached in tests environments, due to the fact that fetching such URL returns: |
3 tasks
|
I just merged #1391. Can you rebase master into this branch? :) |
Hi! Sure! |
EstebanBorai
force-pushed
the
feat/geckodriver-linux-aarch64
branch
from
69dad53
to
e885bc6
Compare
|
Hi @drager! I think this is good to go now! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make sure these boxes are checked! 📦✅
rustfmtinstalledcargo fmton the code base before submitting✨✨ 😄 Thanks so much for contributing to wasm-pack! 😄 ✨✨
Introduces support to download Geckodriver in Linux
aarch64based on artifacts availablein Mozilla's releases: https://github.com/mozilla/geckodriver/releases.