Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optional git env variables #101

Closed
rapiz1 opened this issue Jan 3, 2022 · 1 comment
Closed

Optional git env variables #101

rapiz1 opened this issue Jan 3, 2022 · 1 comment

Comments

@rapiz1
Copy link

rapiz1 commented Jan 3, 2022

Follows up #92

Git repository is not always present along with the source code, e.g. downloading source tarball. If feature git is enabled and no git repository is present, the build script using vergen will fail to run and abort the compilation. I think a better way to handle the situation with no available repository is that simply don't set corresponding Git env vars, instead of failing completely. Then by option_env!, the user can determine a fallback method.

@rapiz1
Copy link
Author

rapiz1 commented Jan 3, 2022

My fault. Just don't return the Err that vergen() returns, then the build script won't fail :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant