fix: update build script for using vergen without a git repo #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A fallback mechanism has been added to build script for letting vergen generate cargo instructions even if not run in a git repository. In such cases, a default vergen configuration is used along with disabled "git" feature thus not generating any git-related environment variables. Signed-off-by: Orhun Parmaksız <orhunparmaksiz@gmail.com>
|
Thanks for catching that! I have figured that fix yesterday but forgotten to include that in the branch.
Your patch looks good to me. Let's wait for the CI.
…---Original---
From: "Orhun ***@***.***>
Date: Wed, Jan 5, 2022 00:38 AM
To: ***@***.***>;
Cc: ***@***.***>;
Subject: [rapiz1/rathole] fix: update build script for using vergen without a git repo (PR #59)
Hey! Recently I tried to build rathole from the source tarball and got this error:
Compiling rathole v0.3.1 (/build/rathole/src/rathole-0.3.1) error: failed to run custom build command for `rathole v0.3.1 (/build/rathole/src/rathole-0.3.1)` Caused by: process didn't exit successfully: `/build/rathole/src/rathole-0.3.1/target/release/build/rathole-b8f03abef0c5fe3e/build-script-build` (exit status: 1) --- stderr Error: could not find repository from '/build/rathole/src/rathole-0.3.1'; class=Repository (6); code=NotFound (-3) warning: build failed, waiting for other jobs to finish... error: build failed
This PR fixes this issue by running vergen twice if it fails, with disabling the "git" feature. This won't be an issue since option_env! is used for these git-related variables.
References:
rustyhorde/vergen#101
rustyhorde/vergen#64 (comment)
You can view, comment on, or merge this pull request online at:
#59
Commit Summary
c5621a1 fix: update build script for using vergen without a git repo
File Changes
(1 file)
M build.rs (10)
Patch Links:
https://github.com/rapiz1/rathole/pull/59.patch
https://github.com/rapiz1/rathole/pull/59.diff
—
Reply to this email directly, view it on GitHub, or unsubscribe.
You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey! Recently I tried to build
ratholefrom the source tarball and got this error:This PR fixes this issue by running
vergentwice if it fails, with disabling the "git" feature. This won't be an issue sinceoption_env!is used for these git-related variables.References:
.gitdirectory is not present rustyhorde/vergen#64 (comment)