Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logs cleanups #856

Merged
merged 14 commits into from
Apr 10, 2021
Merged

Logs cleanups #856

merged 14 commits into from
Apr 10, 2021

Conversation

drazisil
Copy link
Collaborator

@drazisil drazisil commented Apr 9, 2021

No description provided.

@codecov
Copy link

codecov bot commented Apr 9, 2021

Codecov Report

Merging #856 (bbe39de) into main (ebb519a) will increase coverage by 42.16%.
The diff coverage is 64.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##            main     #856       +/-   ##
==========================================
+ Coverage   0.00%   42.16%   +42.16%     
==========================================
  Files         38       34        -4     
  Lines       1739     1703       -36     
  Branches      90       90               
==========================================
+ Hits           0      718      +718     
+ Misses      1739      967      -772     
- Partials       0       18       +18     
Impacted Files Coverage Δ
src/server.js 0.00% <ø> (ø)
src/services/AdminServer/AdminServer.js 18.57% <ø> (+18.57%) ⬆️
src/services/AuthLogin/AuthLogin.js 44.89% <ø> (+44.89%) ⬆️
src/services/MCServer/ClientConnectMsg.js 65.00% <ø> (+65.00%) ⬆️
src/services/MCServer/GenericReplyMsg.js 52.77% <ø> (+52.77%) ⬆️
src/services/MCServer/GenericRequestMsg.js 59.09% <ø> (+59.09%) ⬆️
src/services/MCServer/LobbyServer/npsUserInfo.js 72.72% <ø> (+72.72%) ⬆️
src/services/MCServer/LoginServer/LoginServer.js 31.03% <ø> (+31.03%) ⬆️
src/services/MCServer/LoginServer/npsUserStatus.js 46.87% <ø> (+46.87%) ⬆️
src/services/MCServer/MCOTS/LoginMsg.js 78.94% <ø> (+78.94%) ⬆️
... and 50 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ebb519a...bbe39de. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented Apr 9, 2021

This pull request fixes 1 alert when merging 0de5f7f into ebb519a - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Apr 9, 2021

This pull request fixes 1 alert when merging 978fffa into ebb519a - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Apr 9, 2021

This pull request fixes 1 alert when merging ac26703 into ebb519a - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented Apr 9, 2021

This pull request fixes 1 alert when merging f1df21e into ebb519a - view on LGTM.com

fixed alerts:

  • 1 for Unused variable, import, function or class

@ghost
Copy link

ghost commented Apr 10, 2021

Congratulations 🎉. DeepCode analyzed your code in 0.781 seconds and we found no issues. Enjoy a moment of no bugs ☀️.

👉 View analysis in DeepCode’s Dashboard | Configure the bot

@sonarcloud
Copy link

sonarcloud bot commented Apr 10, 2021

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@lgtm-com
Copy link

lgtm-com bot commented Apr 10, 2021

This pull request fixes 5 alerts when merging bbe39de into ebb519a - view on LGTM.com

fixed alerts:

  • 5 for Unused variable, import, function or class

@drazisil drazisil merged commit 052b5e3 into main Apr 10, 2021
@drazisil drazisil deleted the logs-cleanups branch April 10, 2021 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant