Back merge #7
Closed
Back merge #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change has been taken from the PR at rustyoz#4
This change has been taken from the pull request at rustyoz#4
These changes are from the pull request at rustyoz#3
This is hacky but it should work for now.
In addition to the path segments we want to emit drawinginstructions. We gradually start converting the parsing functions to also emit these instructions.
Also add the close path instruction.
We also make sure that both get drained.
Implementers of this interface are able to return a channel of DrawingInstructions. All SVG elements should implement this interface allowing us to draw all of them.
It hey are not, we will get a deadlock.
This DrawingInstructions signifies that a path element should now be drawn. We need to do this in order to be able to take the line width into account.
Apparently we were adding the same point twice which is not what we wanted to do.
We also make sure that we emit a CloseInstruction regardless of the segment state.
The interface now returns an error channel to which we write the first error that occurs.
We do this for consistency.
Using this struct we can save 40 bytes for each non-Bezier curve instruction. Bezier curve instructions get 8 bytes bigger however.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.