Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back merge #7

Closed
wants to merge 75 commits into from
Closed

Back merge #7

wants to merge 75 commits into from

Commits on May 24, 2017

  1. Update travis config

    This change has been taken from the PR at
    
    rustyoz#4
    Shugyousha committed May 24, 2017
    Configuration menu
    Copy the full SHA
    6541e6d View commit details
    Browse the repository at this point in the history
  2. parser: add a simple test

    This change has been taken from the pull request at
    
    rustyoz#4
    Shugyousha committed May 24, 2017
    Configuration menu
    Copy the full SHA
    9eb05a4 View commit details
    Browse the repository at this point in the history
  3. Add translate transform and transform support for path

    These changes are from the pull request at
    
    rustyoz#3
    Shugyousha committed May 24, 2017
    Configuration menu
    Copy the full SHA
    60fe3ad View commit details
    Browse the repository at this point in the history
  4. Fix some golint issues

    Shugyousha committed May 24, 2017
    Configuration menu
    Copy the full SHA
    705e640 View commit details
    Browse the repository at this point in the history

Commits on May 26, 2017

  1. Configuration menu
    Copy the full SHA
    62b50e5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7213c0f View commit details
    Browse the repository at this point in the history
  3. Make the code work without any groups being present

    This is hacky but it should work for now.
    Shugyousha committed May 26, 2017
    Configuration menu
    Copy the full SHA
    99b8b1f View commit details
    Browse the repository at this point in the history
  4. path: add drawinginstruction

    In addition to the path segments we want to emit drawinginstructions. We
    gradually start converting the parsing functions to also emit these
    instructions.
    Shugyousha committed May 26, 2017
    Configuration menu
    Copy the full SHA
    c2d05b7 View commit details
    Browse the repository at this point in the history
  5. path: add DrawingInstructions emission for line commands

    Also add the close path instruction.
    Shugyousha committed May 26, 2017
    Configuration menu
    Copy the full SHA
    2465871 View commit details
    Browse the repository at this point in the history
  6. Fix golint issues

    Shugyousha committed May 26, 2017
    Configuration menu
    Copy the full SHA
    a4dddda View commit details
    Browse the repository at this point in the history

Commits on May 29, 2017

  1. Remove unneeded field

    Shugyousha committed May 29, 2017
    Configuration menu
    Copy the full SHA
    1a44c83 View commit details
    Browse the repository at this point in the history
  2. Return both channels in our parse function

    We also make sure that both get drained.
    Shugyousha committed May 29, 2017
    Configuration menu
    Copy the full SHA
    ded417f View commit details
    Browse the repository at this point in the history

Commits on May 30, 2017

  1. Configuration menu
    Copy the full SHA
    1156198 View commit details
    Browse the repository at this point in the history
  2. Add circle elements

    Shugyousha committed May 30, 2017
    Configuration menu
    Copy the full SHA
    92104aa View commit details
    Browse the repository at this point in the history
  3. Introduce the DrawingInstructionParser interface

    Implementers of this interface are able to return a channel of
    DrawingInstructions. All SVG elements should implement this interface
    allowing us to draw all of them.
    Shugyousha committed May 30, 2017
    Configuration menu
    Copy the full SHA
    35908bf View commit details
    Browse the repository at this point in the history
  4. Make sure the channels are closed

    It hey are not, we will get a deadlock.
    Shugyousha committed May 30, 2017
    Configuration menu
    Copy the full SHA
    0840c15 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    ac28d3e View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    79565f6 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    6148280 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    bc395a1 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    67202a3 View commit details
    Browse the repository at this point in the history

Commits on May 31, 2017

  1. Add and emit PaintInstruction

    This DrawingInstructions signifies that a path element should now be
    drawn. We need to do this in order to be able to take the line width
    into account.
    Shugyousha committed May 31, 2017
    Configuration menu
    Copy the full SHA
    8f56c5c View commit details
    Browse the repository at this point in the history
  2. Remove PathInstruction

    Shugyousha committed May 31, 2017
    Configuration menu
    Copy the full SHA
    7e6f2a9 View commit details
    Browse the repository at this point in the history
  3. path: don't add the point twice

    Apparently we were adding the same point twice which is not what we
    wanted to do.
    Shugyousha committed May 31, 2017
    Configuration menu
    Copy the full SHA
    1884e15 View commit details
    Browse the repository at this point in the history

Commits on Jun 1, 2017

  1. Configuration menu
    Copy the full SHA
    a547fd6 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f582da2 View commit details
    Browse the repository at this point in the history
  3. path: fix missing fallthrough

    We also make sure that we emit a CloseInstruction regardless of the
    segment state.
    Shugyousha committed Jun 1, 2017
    Configuration menu
    Copy the full SHA
    1c14136 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    dc317f0 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    ee53537 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    ee9a85b View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    7488f08 View commit details
    Browse the repository at this point in the history
  8. path: use the transformed relativ start points

    We were using the non-transformed ones by mistake.
    Shugyousha committed Jun 1, 2017
    Configuration menu
    Copy the full SHA
    f346efe View commit details
    Browse the repository at this point in the history

Commits on Jun 2, 2017

  1. path: consume comma

    The SVG we get sometimes contains commata between points. At the moment
    we only added it to the 'C' command coordinate parsing and we may have
    to add it to other places later.
    Shugyousha committed Jun 2, 2017
    Configuration menu
    Copy the full SHA
    fc8461e View commit details
    Browse the repository at this point in the history
  2. path,svg: make fill attribute a pointer

    That way we can more easily distinguish between the no-attribute-present
    case and the attribute set to "none" case.
    Shugyousha committed Jun 2, 2017
    Configuration menu
    Copy the full SHA
    636b2cb View commit details
    Browse the repository at this point in the history

Commits on Jun 6, 2017

  1. svg: add ParseDrawingInstructions method to Svg

    It would be more elegant to use this method to get all the drawing
    instructions. Sadly, at the moment we rely on knowing whether there is
    a scale operation in the group or not so we cannot use this method yet.
    Shugyousha committed Jun 6, 2017
    Configuration menu
    Copy the full SHA
    26ccc43 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    315946d View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    3c38308 View commit details
    Browse the repository at this point in the history

Commits on Jun 7, 2017

  1. path: don't return an error if there is no Segment

    We are not using Segments and it's not an error for us so we just don't
    return an error here.
    Shugyousha committed Jun 7, 2017
    Configuration menu
    Copy the full SHA
    74beaca View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2017

  1. Start using our own parsing functions

    The potrace SVGs still don't work.
    Shugyousha committed Jun 8, 2017
    Configuration menu
    Copy the full SHA
    f90b181 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    ca2479b View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    56e24a9 View commit details
    Browse the repository at this point in the history
  4. path: the target point becomes the new start point

    In a bezier curve instruction, the target point becomes the new current
    point. This is true when several bezier curve instructions are chained
    as well and that's why we have to update the current relative coordinate.
    Shugyousha committed Jun 8, 2017
    Configuration menu
    Copy the full SHA
    f660519 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    186ef8b View commit details
    Browse the repository at this point in the history
  6. Change the DrawingInstructionParser interface

    We remove the segments channel which is now not needed anymore.
    Shugyousha committed Jun 8, 2017
    Configuration menu
    Copy the full SHA
    1ef8c26 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    989e72e View commit details
    Browse the repository at this point in the history
  8. path: make multiple moveto commands into lineto commands

    According to
    
    https://www.w3.org/TR/SVG2/paths.html#PathDataMovetoCommands
    
    multiple moveto commands have to be interpreted as lineto commands.
    Shugyousha committed Jun 8, 2017
    Configuration menu
    Copy the full SHA
    5629076 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    3bd3f0c View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2017

  1. svg: add test to parse path with absolute lines

    Alexander Döring committed Jun 9, 2017
    Configuration menu
    Copy the full SHA
    a854008 View commit details
    Browse the repository at this point in the history
  2. svg: add parseLineToAbsDI

    Alexander Döring committed Jun 9, 2017
    Configuration menu
    Copy the full SHA
    8295966 View commit details
    Browse the repository at this point in the history
  3. svg: fix error in parseCommandDrawingInstructions

    Alexander Döring committed Jun 9, 2017
    Configuration menu
    Copy the full SHA
    bb54c24 View commit details
    Browse the repository at this point in the history
  4. svg: refactor parseCommand, parseCommandDrawingInstructions

    Alexander Döring committed Jun 9, 2017
    Configuration menu
    Copy the full SHA
    e7bdd4f View commit details
    Browse the repository at this point in the history
  5. Merge branch 'dev'

    Alexander Döring committed Jun 9, 2017
    Configuration menu
    Copy the full SHA
    a23fe10 View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2017

  1. svg: change the DrawingInstructionParser interface

    The interface now returns an error channel to which we write the first
    error that occurs.
    Shugyousha committed Jun 13, 2017
    Configuration menu
    Copy the full SHA
    7217ec3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    f1d5b31 View commit details
    Browse the repository at this point in the history
  3. Merge branch 'dev'

    Alexander Döring committed Jun 13, 2017
    Configuration menu
    Copy the full SHA
    18098fc View commit details
    Browse the repository at this point in the history

Commits on Jun 14, 2017

  1. path: fix test

    Shugyousha committed Jun 14, 2017
    Configuration menu
    Copy the full SHA
    a9bfdc9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8f523a2 View commit details
    Browse the repository at this point in the history
  3. path: change the Stroke field into a pointer

    We do this for consistency.
    Shugyousha committed Jun 14, 2017
    Configuration menu
    Copy the full SHA
    db6563d View commit details
    Browse the repository at this point in the history
  4. drawinginstruction: introduce the CurvePoints struct

    Using this struct we can save 40 bytes for each non-Bezier curve
    instruction. Bezier curve instructions get 8 bytes bigger however.
    Shugyousha committed Jun 14, 2017
    Configuration menu
    Copy the full SHA
    02a00fe View commit details
    Browse the repository at this point in the history

Commits on Jun 22, 2017

  1. Merge branch 'dev'

    Shugyousha committed Jun 22, 2017
    Configuration menu
    Copy the full SHA
    a664773 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d719ede View commit details
    Browse the repository at this point in the history
  3. Merge branch 'dev'

    Shugyousha committed Jun 22, 2017
    Configuration menu
    Copy the full SHA
    e2129cf View commit details
    Browse the repository at this point in the history

Commits on Nov 11, 2017

  1. Configuration menu
    Copy the full SHA
    8690910 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    18dd49f View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    517796d View commit details
    Browse the repository at this point in the history
  4. more DRY path tests

    pdbogen committed Nov 11, 2017
    Configuration menu
    Copy the full SHA
    1bc75e4 View commit details
    Browse the repository at this point in the history

Commits on Jan 5, 2018

  1. Configuration menu
    Copy the full SHA
    a9d845a View commit details
    Browse the repository at this point in the history
  2. t.Logf instead of log.Printf

    pdbogen committed Jan 5, 2018
    Configuration menu
    Copy the full SHA
    65d585f View commit details
    Browse the repository at this point in the history
  3. simplify test loop

    pdbogen committed Jan 5, 2018
    Configuration menu
    Copy the full SHA
    902a069 View commit details
    Browse the repository at this point in the history
  4. go fmt

    pdbogen committed Jan 5, 2018
    Configuration menu
    Copy the full SHA
    7c977e8 View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2018

  1. Configuration menu
    Copy the full SHA
    59b09cb View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    48c3d6c View commit details
    Browse the repository at this point in the history

Commits on Dec 24, 2018

  1. Configuration menu
    Copy the full SHA
    91a71ba View commit details
    Browse the repository at this point in the history

Commits on Jan 7, 2019

  1. fixed crash on text in group

    JAicewizard authored and Shugyousha committed Jan 7, 2019
    Configuration menu
    Copy the full SHA
    0047d6d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d22ae5b View commit details
    Browse the repository at this point in the history