Implement conversion from non-det transitions to enumeration #40
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implement From conversions from non-deterministic transition enums to the state enum, if enabled.
|
Hey @lopsided98, thank you for investing some time and contributing! Before I proceed with review, could you provide some tests over your feature? You can take a look at the existing ones in Let me know if you have further questions! |
|
I added a simple test. Let me know what you think. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement
Fromconversions from non-deterministic transition enums to the state enum, if enabled. This makes it a lot nicer to work with non-deterministic transitions.I've never worked on a proc macro before, so I'm not sure if my implementation is the best.