Redox support #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruuda
reviewed
Jun 22, 2017
src/lib.rs
Outdated
| #[cfg(target_os = "redox")] | ||
| #[inline] | ||
| fn get_internal() -> usize { | ||
| syscall::getpid().unwrap() |
There was a problem hiding this comment.
I am not familiar with Redox internals, but on Linux at least there is a distinction between the process id and the thread id. Could you please add a comment to explain why getpid is the right thing to call here? Is there even a distinction between processes and threads on Redox?
There was a problem hiding this comment.
It is true that threads are simply processes on Redox, which share memory with other processes.
There was a problem hiding this comment.
In other words, creating a new thread will create a new process ID
|
Thanks! Should I publish a new version on crates.io? |
|
Yes, that would be helpful. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.