Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show min/max/average of the visible zoom timespan #219

Closed
laurijamsa opened this issue Sep 17, 2022 · 6 comments
Closed

Show min/max/average of the visible zoom timespan #219

laurijamsa opened this issue Sep 17, 2022 · 6 comments

Comments

@laurijamsa
Copy link
Member

laurijamsa commented Sep 17, 2022

Something like this:

image

Show them even if user isn't hovering on top of the graph. Note that the average calculation has to take into account if some data points are missing.

@DG12
Copy link

DG12 commented Sep 18, 2022

Looks like a LOT of data points. More than one or two per pixel. Things get slow. :-)

@io53
Copy link
Collaborator

io53 commented Sep 18, 2022

Looks like a LOT of data points. More than one or two per pixel. Things get slow. :-)

How can you tell that there is more data than the screen can show? It's not rendered 😅
The graph lib handles loads and loads of datapoints with ease. Resizing is a bit intense tho, but thats another topic :).

@DG12
Copy link

DG12 commented Sep 19, 2022

And how about min avg max and...
GraphPretty

@io53
Copy link
Collaborator

io53 commented Feb 23, 2023

Todo:

  • Add info button to the right of min/max/avg
  • take zoom into account when calculating stats on data in the graph view, not all data loaded.

io53 pushed a commit that referenced this issue Mar 2, 2023
io53 pushed a commit that referenced this issue Mar 2, 2023
io53 pushed a commit that referenced this issue Mar 2, 2023
io53 pushed a commit that referenced this issue Mar 3, 2023
io53 pushed a commit that referenced this issue Mar 3, 2023
io53 pushed a commit that referenced this issue Mar 7, 2023
io53 pushed a commit that referenced this issue Mar 7, 2023
io53 pushed a commit that referenced this issue Mar 8, 2023
io53 pushed a commit that referenced this issue Mar 8, 2023
io53 pushed a commit that referenced this issue Mar 8, 2023
io53 pushed a commit that referenced this issue Mar 8, 2023
@io53 io53 assigned laurijamsa and markoaamunkajo and unassigned io53 Mar 9, 2023
@io53 io53 assigned io53 and unassigned laurijamsa and markoaamunkajo Mar 16, 2023
io53 pushed a commit that referenced this issue Mar 22, 2023
io53 pushed a commit that referenced this issue Mar 22, 2023
@io53 io53 assigned laurijamsa and unassigned io53 Mar 22, 2023
@markoaamunkajo markoaamunkajo added the bug Something isn't working label Mar 23, 2023
@markoaamunkajo
Copy link
Collaborator

@io53 using same card for improving the mobile view with cramped average as in screenshot

cramped_mobile_iphone_chrome

@DG12
Copy link

DG12 commented Mar 23, 2023

"Time: 2023-" seems unnecessary.
":00" seconds unnecessary too?
Average could be "avgl"

io53 pushed a commit that referenced this issue Mar 26, 2023
@io53 io53 assigned markoaamunkajo and unassigned io53 Mar 26, 2023
@laurijamsa laurijamsa assigned io53 and unassigned markoaamunkajo Mar 30, 2023
@laurijamsa laurijamsa removed the bug Something isn't working label Mar 30, 2023
@io53 io53 assigned markoaamunkajo and unassigned io53 Apr 6, 2023
@markoaamunkajo markoaamunkajo removed their assignment Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants