Fixed shadows overlapping when in cumulative mode.

[Tordek]

Split drawing in two steps: First draw shadows, then draw datasets.

[Tordek]

Hi!

This PR was brought to you by the CPAN Pull Request Challenge!

I'm new to Perl, and I tried to make the simplest thing that worked; please do not hesitate to mention anything that can be improved, if need be.

[ruz]

Sorry for delay. I'm maintainer of the module so a demo would be cool, may be update to samples if there is apropriate place exists for the sample. If this work is based on a bug report then please mention it here. I just released 1.49 with a few clean ups and fixes and abolutely don't mind to release 1.50 with this fixes in place after I get more context to simplify code review.

[Tordek]

Hi, sorry for the extreme delay, I had college to attend to.

I just verified that the bug is present in 1.49.

This patch should fix the first bug in BUGS, "Subject: Bug in shadow handling with cumulative bar charts", which is (erroneously?) marked as fixed in the changelog for 12 Jun 2002 - 21 Jun 2002.

The BUGS file contains an example:

#!/usr/bin/perl 
use strict;
use warnings; 
use GD::Graph::bars (); 

my @data = (
    [qw(ASP Perl Ruby CFML Java)],
    [qw(4 9 7 2 5)],
    [qw(2 6 7 2 5)]
); my
$graph = GD::Graph::bars->new(400, 300);
$graph->set(
    x_label => 'Language',
    y_label => 'Coolness',
    y_max_value=> 20,
    title=> 'How cool is your language?',
    bar_spacing=> 1,
    transparent=> 0,
    shadow_depth=> -4,
    cumulate => 1
); 
my $gd = $graph->plot(\@data);
my $png = $gd->png;

open FOO, ">cumbug.png" or die $!;
binmode FOO;
print FOO $png;

Should I put this in the samples directory?

[ruz]

Ty for your reply. Ping me by replying in a few weeks if I don't get back
to this.

On Sun, Jun 14, 2015 at 11:08 AM, Guillermo O. Freschi <
notifications@github.com> wrote:

Hi, sorry for the extreme delay, I had college to attend to.

This patch should fix the first bug in BUGS, "Subject: Bug in shadow
handling with cumulative bar charts", which is (erroneously?) marked as
fixed in the changelog for 12 Jun 2002 - 21 Jun 2002.

The BUGS file contains an example:

#!/usr/bin/perl
use strict;
use warnings;
use GD::Graph::bars ();

my @DaTa = (
[qw(ASP Perl Ruby CFML Java)],
[qw(4 9 7 2 5)],
[qw(2 6 7 2 5)]
); my
$graph = GD::Graph::bars->new(400, 300);
$graph->set(
x_label => 'Language',
y_label => 'Coolness',
y_max_value=> 20,
title=> 'How cool is your language?',
bar_spacing=> 1,
transparent=> 0,
shadow_depth=> -4,
cumulate => 1
);
my $gd = $graph->plot(@DaTa);
my $png = $gd->png;

open FOO, ">cumbug.png" or die $!;
binmode FOO;
print FOO $png;

Should I put this in the samples directory?

—
Reply to this email directly or view it on GitHub
#4 (comment).

Best regards, Ruslan.

[Tordek]

Hi! Just pinging as requested!

[ruz]

thank you