Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid undefined process in webpack v5 #1

Merged
merged 1 commit into from
Jan 25, 2021

Conversation

pro-wh
Copy link
Contributor

@pro-wh pro-wh commented Jan 22, 2021

Webpack 5 no longer provides a polyfill for process. This adds a check so that we don't crash when immediately reaching for process.browser.

@rvagg
Copy link
Owner

rvagg commented Jan 25, 2021

Ahh, good catch, I haven't touched v5 yet so am flying a little blind. Would it be safer to global.process this to avoid invoking any kind of automatic bundle detection like it's doing with Buffer?

@pro-wh
Copy link
Contributor Author

pro-wh commented Jan 25, 2021

I've had nothing come up during compilation to the effect that it recommends something for polyfilling process. What I've seen about webpack 5 is that it no longer does this automatic polyfill bundling.

@rvagg
Copy link
Owner

rvagg commented Jan 25, 2021

ok, we'll see then I guess! thanks for this and the other PRs, great work

@rvagg rvagg merged commit e9fd211 into rvagg:master Jan 25, 2021
@pro-wh
Copy link
Contributor Author

pro-wh commented Jan 25, 2021

Thanks for going through our changes (:

@pro-wh pro-wh deleted the pro-wh/feature/webpack5 branch January 25, 2021 18:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants