Fixed some jslint identified issues.

rvernagus · Feb 10, 2013 · 5ea7487 · 5ea7487
1 parent b863265
commit 5ea7487
Show file tree

Hide file tree

Showing 4 changed files with 18 additions and 9 deletions.
diff --git a/grunt.js b/grunt.js
@@ -1,11 +1,21 @@
+var files = ['*.js', 'lib/**/*.js', 'test/**/*.js'];
+
 module.exports = function(grunt) {
   grunt.loadNpmTasks('grunt-mocha-test');
   grunt.initConfig({
     lint: {
-      files: ['*.js', 'lib/**/*.js']
+      files: files
     },
     mochaTest: {
       tests: ['test/**/*.js']
+    },
+    mochaTestConfig: {
+      tests: {
+
+      },
+      acceptanceTests: {
+
+      }
     }
   });
   grunt.registerTask('default', 'lint mochaTest');

diff --git a/package.json b/package.json
@@ -24,7 +24,8 @@
   "devDependencies": {
     "grunt-mocha-test": "*",
     "mocha": "~1.7.4",
-    "nock": "~0.14.3"
+    "nock": "~0.14.3",
+    "grunt": "~0.3.17"
   },
   "author": "Ray Vernagus",
   "license": "MIT",

diff --git a/test/geoservices.converter.test.js b/test/geoservices.converter.test.js
@@ -13,9 +13,9 @@ describe('geoservices converter', function() {
 
     it('should error upon empty geometry', function() {
       this.esriFeature.geometry = {};
-      assert.throws((function() {
+      assert.throws(function() {
         geoservices.convert.toGeoJSON(this.esriFeature);
-      }), Error);
+      }, Error);
     });
 
     it('should convert a point', function() {

diff --git a/test/geoservices.test.js b/test/geoservices.test.js
@@ -13,14 +13,14 @@ var expectRequest = function(requestedPath, expectedPath, response, method, filt
 };
 
 var expectGetRequest = function(requestedPath, expectedPath, response, filter) {
-  if (filter == null) {
+  if (filter === undefined) {
     filter = true;
   }
   return expectRequest(requestedPath, expectedPath, response, 'get', filter);
 };
 
 var expectPostRequest = function(requestedPath, expectedPath, response, filter) {
-  if (filter == null) {
+  if (filter === undefined) {
     filter = true;
   }
   return expectRequest(requestedPath, expectedPath, response, 'post', filter);
@@ -40,9 +40,7 @@ var getUrlTest = function(requestedPath, expectedPath, filter) {
 };
 
 var postUrlTest = function(requestedPath, expectedPath, response, filter) {
-  if (response == null) {
-    response = '{}';
-  }
+  response = response || '{}';
   return function(done) {
     expectPostRequest(requestedPath, expectedPath, response, filter);
     geoservices.post({