-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
in terminal opened inside rvm project, cding out uses system ruby instead of rvm default #2531
Comments
this should do it, please let me know if it does not |
yup, that got it. thanks. |
... however, this seems to have reverted the effects of the fix for #2519. now when I open a new tab inside a rvm project, the rvm default ruby is used instead of the project's ruby. (gemset is set correctly though) |
has to be a bug, I will investigate |
the above should improve things, I have also added extra test - but it works (compared to the other failing one which seams to be related to this problem) ... can someone retest it after |
Didn't fix the problem I was having on #2527 |
no, I still have the same behavior as #2519 (not the behavior described actually in this issue) |
yeah, I know there is something, I just can not find a test that will reproduce it and tell me what is wrong |
added more tests and a small fix, please give it a go after |
ok so I have finally reproduced the problem on travis, I can not reproduce it locally, but maybe I can debug it on travis, it will take some time, but it's progress |
hmm, so the test passes after removing |
…confirmations ruby is loaded, update rvm/rvm#2531
ok so I have added tests simulating the problem and none of them fails right now, I had to do one change to make the tests work - it could be the one that will make it work for you, please test again after |
Still no luck unfortunately :/ |
please download this two files (click on the
and then run: gem install tf
tf --text load_ruby-version_comment_test.sh rvm_project_rvmrc_comment_test.sh gist the output |
Here is the gist. Thanks to the test I discovered that everything works fine so long as I don't have a default ruby set, so |
this is interesting all the tests pass, the |
I'll poke around but it sounds like it's pretty idiosyncratic to my setup so I must just have something weird somewhere, not a big deal |
actually I was getting this report for some time, but I can not reproduce this in tests, as I can not reproduce it - I do not know what to fix. |
gist for me of |
@ethco oh it looks like you can reproduce the problem! please confirm you get the same after: rvm get head
rvm reload |
one fewer failure after get head: https://gist.github.com/ethco/6890585e6ddf1f9b9481 |
@ethco please get this test https://gist.github.com/mpapis/001a76111d9f42a8e1e7 and run it with: tf --text failing_load_comment_test.sh 2>&1 | tee big.log please gist |
it looks like i found one, please retest after |
works for me 👍 |
looks good. behavior seems correct now and the tf tests all pass. |
assuming it's all good now, will release new version after reviewing rest of the tickets |
Fixed for me too! |
yay! |
and released as |
Still getting the same problem with "rvm 1.26.11" |
Didn't work for me on |
this one is weird.
this continues if I then cd back into any rvm project (switches to the project's ruby) and then back out to any non-rvm directory (uses system ruby instead of rvm default ruby)
this doesn't happen when the terminal is initially opened outside of an rvm-enabled project - it correctly uses the rvm default ruby, switches correctly when cding into a rvm project, and switches back to the rvm default ruby when cding back out.
The text was updated successfully, but these errors were encountered: